fix: numerous small fixes to allow bigtable-admin by software-dov · Pull Request #660 · googleapis/gapic-generator-python · GitHub
Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: numerous small fixes to allow bigtable-admin#660

Merged
software-dov merged 2 commits into
googleapis:masterfrom
software-dov:bigtable-admin-fixings
Oct 19, 2020
Merged

fix: numerous small fixes to allow bigtable-admin#660
software-dov merged 2 commits into
googleapis:masterfrom
software-dov:bigtable-admin-fixings

Conversation

@software-dov

Copy link
Copy Markdown
Contributor

Includes:

  • tweaked logic around defining recursive message types
  • more sophisticated logic for generating unit tests using recursive
    message types
  • flattened map-y fields are handled properly
  • fixed a corner case where a method has a third-party request object
    and flattened fields

Includes:
* tweaked logic around defining recursive message types
* more sophisticated logic for generating unit tests using recursive
message types
* flattened map-y fields are handled properly
* fixed a corner case where a method has a third-party request object
and flattened fields
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2020
@codecov

codecov Bot commented Oct 14, 2020

Copy link
Copy Markdown

@software-dov

Copy link
Copy Markdown
Contributor Author

Open review bump

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐢
🐢 🐢
🐢 🐢 🐢

@software-dov software-dov added the automerge Merge the pull request once unit tests and other checks pass. label Oct 19, 2020
@software-dov software-dov merged commit 09692c4 into googleapis:master Oct 19, 2020
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 19, 2020
gcf-merge-on-green Bot pushed a commit that referenced this pull request Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants