{{ message }}
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
fix: rendering mock values for recursive messages no longer crashes#587
Merged
Conversation
Protobuf allows recursive message types, i.e. messages whose fields
are of the same type as the message itself.
message Foo {
Foo foo = 1; // Degenerate case
}
A real world example is bigquery.v2.data:RowFilter
The solution in this commit is an artifical cap on the depth of
recursion in rendering mock values.
software-dov
requested review from
arithmetic1728,
busunkim96,
crwilcox,
lukesneeringer and
vchudnov-g
google-cla
Bot
added
the
cla: yes
Contributor
|
Does it make sense to add a message like this to https://github.com/googleapis/gapic-showcase? |
arithmetic1728
approved these changes
Sep 3, 2020
Contributor
Author
|
It definitely sounds like a good idea to add a recursive showcase message type. I'll file an issue there. |
Contributor
Author
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protobuf allows recursive message types, i.e. messages whose fields
are of the same type as the message itself.
A real world example is bigquery.v2.data:RowFilter
These recursive types cause a problem when trying to render
mock values for unit tests because there's no inherent limit on
when to stop rendering nested values.
The solution in this commit is an artifical cap on the depth of
recursion in rendering mock values.