FilesExpand file tree

 main

/

DirectStateMutation.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

20 lines (18 loc) · 599 Bytes

 main

/

DirectStateMutation.ql

Copy path

Top

File metadata and controls

• Code
• Blame

20 lines (18 loc) · 599 Bytes

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

/**

* @name Direct state mutation

* @description Mutating the state of a React component directly may lead to

* lost updates.

* @kind problem

* @problem.severity warning

* @id js/react/direct-state-mutation

* @tags reliability

* frameworks/react

* @precision very-high

*/

import semmle.javascript.frameworks.React

from DataFlow::PropWrite pwn, ReactComponent c

where

pwn.getBase() = c.getAStateAccess() and

// writes in constructors are ok

not pwn.getContainer() instanceof Constructor

select pwn, "Use `setState` instead of directly modifying component state."