Add a direct test of run_commit_hook · gitpython-developers/GitPython@e148647 · GitHub
Skip to content

Commit e148647

Browse files
committed
Add a direct test of run_commit_hook
This has three benefits: - run_commit_hook is public, being listed in git.index.fun.__all__, so it makes sense for it to have its own test. - When investigating (future, or current xfail-covered) failure of functions that use run_commit_hook, it will be useful to compare the results of other tests that already do exist to that of a direct test of run_commit_hook. - When changing which bash.exe run_commit_hook selects to use on Windows (including to ameliorate the limitation covered by the WinBashStatus.WslNoDistro xfail marks, or to attempt other possible changes suggested in #1745), or even just to investigate the possibility of doing so, it will make sense to add tests like this test but for more specific conditions or edge cases. Having this typical-case test to compare to should be helpful both for writing such tests and for efficiently verifying that the conditions they test are really the triggers for any failures.
1 parent f664a0b commit e148647

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

test/test_index.py

Lines changed: 19 additions & 1 deletion

0 commit comments

Comments
 (0)