{{ message }}
Commit cd175a5
committed
Remove no-effect
It looked like test_untracked_files was sometimes skipped, and
specifically that it would be skipped on Cygwin. But the `@skipIf`
on it had the condition:
HIDE_WINDOWS_KNOWN_ERRORS and Git.is_cygwin()
HIDE_WINDOWS_KNOWN_ERRORS can only ever be true if it is set to a
truthy value directly (not an intended use as it's a "constant"),
or on native Windows systems: no matter how the environment
variable related to it is set, it's only checked if is_win, which
is set by checking os.name, which is only "nt" on native Windows
systems, not Cygwin.
So whenever HIDE_WINDOWS_KNOWN_ERRORS is true Git.is_cygwin() will
be false. Thus this condition is never true and the test was never
being skipped anyway: it was running and passing on Cygwin.@skipIf on test_untracked_files1 parent b198bf1 commit cd175a5
1 file changed
Lines changed: 2 additions & 12 deletions

0 commit comments