test, deps: FIX `mock` deps on py3. · gitpython-developers/GitPython@7842e92 · GitHub
Skip to content

Commit 7842e92

Browse files
committed
test, deps: FIX mock deps on py3.
+ Del extra spaces, import os.path as osp
1 parent f73468b commit 7842e92

5 files changed

Lines changed: 33 additions & 21 deletions

File tree

git/cmd.py

Lines changed: 8 additions & 9 deletions

git/test/lib/asserts.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
assert_false
1717
)
1818

19-
from mock import patch
19+
try:
20+
from unittest.mock import patch
21+
except ImportError:
22+
from mock import patch
2023

2124
__all__ = ['assert_instance_of', 'assert_not_instance_of',
2225
'assert_none', 'assert_not_none',

git/test/test_commit.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,11 @@
3434
import os
3535
from datetime import datetime
3636
from git.objects.util import tzoffset, utc
37-
from mock import Mock
37+
38+
try:
39+
from unittest.mock import Mock
40+
except ImportError:
41+
from mock import Mock
3842

3943

4044
def assert_commit_serialization(rwrepo, commit_id, print_performance_info=False):
@@ -343,9 +347,9 @@ def test_gpgsig(self):
343347
cstream = BytesIO()
344348
cmt._serialize(cstream)
345349
assert re.search(r"^gpgsig <test\n dummy\n sig>$", cstream.getvalue().decode('ascii'), re.MULTILINE)
346-
350+
347351
self.assert_gpgsig_deserialization(cstream)
348-
352+
349353
cstream.seek(0)
350354
cmt.gpgsig = None
351355
cmt._deserialize(cstream)
@@ -355,27 +359,27 @@ def test_gpgsig(self):
355359
cstream = BytesIO()
356360
cmt._serialize(cstream)
357361
assert not re.search(r"^gpgsig ", cstream.getvalue().decode('ascii'), re.MULTILINE)
358-
362+
359363
def assert_gpgsig_deserialization(self, cstream):
360364
assert 'gpgsig' in 'precondition: need gpgsig'
361-
365+
362366
class RepoMock:
363367
def __init__(self, bytestr):
364368
self.bytestr = bytestr
365-
369+
366370
@property
367371
def odb(self):
368372
class ODBMock:
369373
def __init__(self, bytestr):
370374
self.bytestr = bytestr
371-
375+
372376
def stream(self, *args):
373377
stream = Mock(spec_set=['read'], return_value=self.bytestr)
374378
stream.read.return_value = self.bytestr
375379
return ('binsha', 'typename', 'size', stream)
376-
380+
377381
return ODBMock(self.bytestr)
378-
382+
379383
repo_mock = RepoMock(cstream.getvalue())
380384
for field in Commit.__slots__:
381385
c = Commit(repo_mock, b'x' * 20)

git/test/test_git.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
# the BSD License: http://www.opensource.org/licenses/bsd-license.php
77
import os
88
import sys
9-
import mock
109
import subprocess
1110

1211
from git.test.lib import (
@@ -28,6 +27,11 @@
2827

2928
from git.compat import PY3
3029

30+
try:
31+
from unittest import mock
32+
except ImportError:
33+
import mock
34+
3135

3236
class TestGit(TestBase):
3337

setup.py

Lines changed: 3 additions & 1 deletion

0 commit comments

Comments
 (0)