Add type to objects.base.new()

Yobmod · Yobmod · commit 35231dba2f12 · 2021-07-31T18:04:28.000+01:00
diff --git a/git/objects/base.py b/git/objects/base.py
@@ -25,6 +25,7 @@
     from .tree import Tree
     from .blob import Blob
     from .submodule.base import Submodule
+    from git.refs.reference import Reference
 
 IndexObjUnion = Union['Tree', 'Blob', 'Submodule']
 
@@ -59,7 +60,7 @@ def __init__(self, repo: 'Repo', binsha: bytes):
         assert len(binsha) == 20, "Require 20 byte binary sha, got %r, len = %i" % (binsha, len(binsha))
 
     @classmethod
-    def new(cls, repo: 'Repo', id):  # @ReservedAssignment
+    def new(cls, repo: 'Repo', id: Union[str, 'Reference']) -> Commit_ish:
         """
         :return: New Object instance of a type appropriate to the object type behind
             id. The id of the newly created object will be a binsha even though
diff --git a/pyproject.toml b/pyproject.toml
@@ -19,7 +19,7 @@ filterwarnings = 'ignore::DeprecationWarning'
 # filterwarnings ignore::WarningType  # ignores those warnings
 
 [tool.mypy]
-disallow_untyped_defs = true
+#disallow_untyped_defs = true
 no_implicit_optional = true
 warn_redundant_casts = true
 # warn_unused_ignores = True
