Mark `test_installation` xfail on Cygwin CI · gitpython-developers/GitPython@2ae697d · GitHub
Skip to content

Commit 2ae697d

Browse files
committed
Mark test_installation xfail on Cygwin CI
Together with #2007, this works around #2004, allowing all tests to pass on Cygwin CI. In #2007, installation of the environment in which tests run was fixed by downloading and running the `get-pip.py` bootstrap script. If we were to modify our helper that sets up the (separate) virtual environment in `test_installation` so that it does the same thing (or conditionally does so on CI, since the problem does not seem to happen in local installations), that would likely "fix" this more thoroughly, allowing the test to pass. But part of the goal of the installation test is to test that installation works in a typical environment on the platform it runs on. So it is not obivous that making it pass in that way would be an improvement compared to marking it `xfail` with the exception type that occurs due to #2004. So this just does that, for now.
1 parent fe7533e commit 2ae697d

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

test/test_installation.py

Lines changed: 8 additions & 0 deletions

0 commit comments

Comments
 (0)