App Secret in public repo · Issue #75 · gitify-app/gitify · GitHub
Skip to content

App Secret in public repo #75

Closed
Closed
App Secret in public repo#75
Labels
enhancementNew feature or enhancement to existing functionality
Milestone
Release 0.0.14

Description

@icotting
icotting
opened on Jul 30, 2015

Maybe you don't want this in the repository since it is public? Excellent blog post about OAuth though ... much appreciated.

https://github.com/ekonstantinidis/gitify/blob/master/src/js/components/login.js#L21

Activity

  1. manosim commented on Jul 30, 2015

    @manosim
    manosim
    on Jul 30, 2015
    Member

    Thank you for the nice words @icotting ! Will have a further look about the client secret key in the next release!

  2. manosim
    added this to the Release 0.0.14 milestone on Jul 30, 2015
  3. manosim
    added
    enhancementNew feature or enhancement to existing functionality
    on Jul 30, 2015
  4. manosim
    closed this as completedin #80on Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or enhancement to existing functionality

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions