FilesExpand file tree

v1.12.0

/

scope_filter_test.go

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

238 lines (213 loc) · 6.67 KB

v1.12.0

/

scope_filter_test.go

Copy path

Top

File metadata and controls

• Code
• Blame

238 lines (213 loc) · 6.67 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

52

53

54

55

56

57

58

59

60

61

62

63

64

65

66

67

68

69

70

71

72

73

74

75

76

77

78

79

80

81

82

83

84

85

86

87

88

89

90

91

92

93

94

95

96

97

98

99

100

101

102

103

104

105

106

107

108

109

110

111

112

113

114

115

116

117

118

119

120

121

122

123

124

125

126

127

128

129

130

131

132

133

134

135

136

137

138

139

140

141

142

143

144

145

146

147

148

149

150

151

152

153

154

155

156

157

158

159

160

161

162

163

164

165

166

167

168

169

170

171

172

173

174

175

176

177

178

179

180

181

182

183

184

185

186

187

188

189

190

191

192

193

194

195

196

197

198

199

200

201

202

203

204

205

206

207

208

209

210

211

212

213

214

215

216

217

218

219

220

221

222

223

224

225

226

227

228

229

230

231

232

233

234

235

236

237

238

package github

import (

"context"

"testing"

"github.com/github/github-mcp-server/pkg/inventory"

"github.com/github/github-mcp-server/pkg/scopes"

"github.com/github/github-mcp-server/pkg/translations"

"github.com/modelcontextprotocol/go-sdk/mcp"

"github.com/stretchr/testify/assert"

"github.com/stretchr/testify/require"

)

func TestCreateToolScopeFilter(t *testing.T) {

toolNoScopes := &inventory.ServerTool{

Tool: mcp.Tool{Name: "no_scopes_tool"},

}

toolEmptyScopes := &inventory.ServerTool{

Tool: mcp.Tool{Name: "empty_scopes_tool"},

ScopeAccess: scopes.NoScopes(),

}

toolRepoScope := &inventory.ServerTool{

Tool: mcp.Tool{Name: "repo_tool"},

ScopeAccess: scopes.RequireAll(scopes.Repo),

}

toolRepoScopeReadOnly := &inventory.ServerTool{

Tool: mcp.Tool{

Name: "repo_tool_readonly",

Annotations: &mcp.ToolAnnotations{ReadOnlyHint: true},

},

ScopeAccess: publicReadAccess(scopes.Repo),

}

toolPublicRepoScope := &inventory.ServerTool{

Tool: mcp.Tool{Name: "public_repo_tool"},

ScopeAccess: scopes.RequireAll(scopes.PublicRepo),

}

toolPublicRepoScopeReadOnly := &inventory.ServerTool{

Tool: mcp.Tool{

Name: "public_repo_tool_readonly",

Annotations: &mcp.ToolAnnotations{ReadOnlyHint: true},

},

ScopeAccess: publicReadAccess(scopes.PublicRepo),

}

toolGistScope := &inventory.ServerTool{

Tool: mcp.Tool{Name: "gist_tool"},

ScopeAccess: scopes.RequireAll(scopes.Gist),

}

toolMultiScope := &inventory.ServerTool{

Tool: mcp.Tool{Name: "multi_scope_tool"},

ScopeAccess: inventory.ScopeAccess{

Visible: func(activeScopes []string) bool {

return scopes.HasAll(activeScopes, scopes.Repo) || scopes.HasAll(activeScopes, scopes.AdminOrg)

},

},

}

toolConjunctiveScopes := &inventory.ServerTool{

Tool: mcp.Tool{Name: "conjunctive_scope_tool"},

ScopeAccess: scopes.RequireAll(scopes.DeleteRepo, scopes.Repo),

}

tests := []struct {

name string

tokenScopes []string

tool *inventory.ServerTool

expected bool

}{

{

name: "tool with no scopes is always visible",

tokenScopes: []string{},

tool: toolNoScopes,

expected: true,

},

{

name: "tool with empty scopes is always visible",

tokenScopes: []string{"repo"},

tool: toolEmptyScopes,

expected: true,

},

{

name: "token with exact scope can see tool",

tokenScopes: []string{"repo"},

tool: toolRepoScope,

expected: true,

},

{

name: "token with parent scope can see child-scoped tool",

tokenScopes: []string{"repo"},

tool: toolPublicRepoScope,

expected: true,

},

{

name: "token missing required scope cannot see tool",

tokenScopes: []string{"gist"},

tool: toolRepoScope,

expected: false,

},

{

name: "token with unrelated scope cannot see tool",

tokenScopes: []string{"repo"},

tool: toolGistScope,

expected: false,

},

{

name: "token with one of multiple accepted scopes can see tool",

tokenScopes: []string{"admin:org"},

tool: toolMultiScope,

expected: true,

},

{

name: "empty token scopes cannot see scoped tools",

tokenScopes: []string{},

tool: toolRepoScope,

expected: false,

},

{

name: "empty token scopes CAN see read-only repo tools (public repos)",

tokenScopes: []string{},

tool: toolRepoScopeReadOnly,

expected: true,

},

{

name: "empty token scopes CAN see read-only public_repo tools",

tokenScopes: []string{},

tool: toolPublicRepoScopeReadOnly,

expected: true,

},

{

name: "token with multiple scopes where one matches",

tokenScopes: []string{"gist", "repo"},

tool: toolPublicRepoScope,

expected: true,

},

{

name: "token must satisfy every required scope group",

tokenScopes: []string{"delete_repo"},

tool: toolConjunctiveScopes,

expected: false,

},

{

name: "token satisfying every required scope group can see tool",

tokenScopes: []string{"delete_repo", "repo"},

tool: toolConjunctiveScopes,

expected: true,

},

}

for _, tt := range tests {

t.Run(tt.name, func(t *testing.T) {

filter := CreateToolScopeFilter(tt.tokenScopes)

result, err := filter(context.Background(), tt.tool)

require.NoError(t, err)

assert.Equal(t, tt.expected, result, "filter result should match expected")

})

}

}

func TestCreateToolScopeFilter_Integration(t *testing.T) {

// Test integration with inventory builder

tools := []inventory.ServerTool{

{

Tool: mcp.Tool{Name: "public_tool"},

Toolset: inventory.ToolsetMetadata{ID: "test"},

ScopeAccess: scopes.NoScopes(),

},

{

Tool: mcp.Tool{Name: "repo_tool"},

Toolset: inventory.ToolsetMetadata{ID: "test"},

ScopeAccess: scopes.RequireAll(scopes.Repo),

},

{

Tool: mcp.Tool{Name: "gist_tool"},

Toolset: inventory.ToolsetMetadata{ID: "test"},

ScopeAccess: scopes.RequireAll(scopes.Gist),

},

}

// Create filter for token with only "repo" scope

filter := CreateToolScopeFilter([]string{"repo"})

// Build inventory with the filter

inv, err := inventory.NewBuilder().

SetTools(tools).

WithToolsets([]string{"test"}).

WithFilter(filter).

Build()

require.NoError(t, err)

// Get available tools

availableTools := inv.AvailableTools(context.Background())

// Should see public_tool and repo_tool, but not gist_tool

assert.Len(t, availableTools, 2)

toolNames := make([]string, len(availableTools))

for i, tool := range availableTools {

toolNames[i] = tool.Tool.Name

}

assert.Contains(t, toolNames, "public_tool")

assert.Contains(t, toolNames, "repo_tool")

assert.NotContains(t, toolNames, "gist_tool")

}

func TestCreateToolScopeFilterSupportsAlternativePaths(t *testing.T) {

filter := CreateToolScopeFilter([]string{"repo"})

unscopedFilter := CreateToolScopeFilter(nil)

tools := []inventory.ServerTool{

ListIssueFields(translations.NullTranslationHelper),

ListIssueTypes(translations.NullTranslationHelper),

UIGet(translations.NullTranslationHelper),

}

for i := range tools {

allowed, err := filter(context.Background(), &tools[i])

require.NoError(t, err)

assert.True(t, allowed, "%s should be visible with a repo-only token", tools[i].Tool.Name)

allowed, err = unscopedFilter(context.Background(), &tools[i])

require.NoError(t, err)

assert.True(t, allowed, "%s should remain visible when a public-repository path is plausible", tools[i].Tool.Name)

}

}

func publicReadAccess(required scopes.Scope) inventory.ScopeAccess {

access := scopes.RequireAll(required)

access.Visible = func([]string) bool { return true }

return access

}