{{ message }}
Use Copilot CLI release assets in Go bundler - #2529
Closed
qmuntal wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review tier: Lite
Findings: 3
New issues introduced by this change (4)
What changed in this PR
This PR updates the Go bundler and embedded installer to source Copilot CLI artifacts from pinned GitHub release assets, verify them via SHA256SUMS.txt, and improve caching/security hardening around downloads and archive handling.
Changes:
- Switch bundling from npm tarballs to Copilot CLI GitHub release archives with checksum verification and bounded retries.
- Add validated bundle metadata caching and simplify generation to a single platform-specific embedded Go source file.
- Refactor embedded installer to use shared verified-file installation helpers and a shared install-dir preparation/lock step.
| File | Description |
|---|---|
| go/internal/embeddedcli/embeddedcli.go | Refactors installation flow to share install-dir preparation and verified atomic installs for binary/runtime artifacts. |
| go/cmd/bundler/main.go | Implements release-asset download + SHA256SUMS verification, retry logic, bundle metadata cache, and single-file Go embed generation. |
| go/cmd/bundler/main_test.go | Adds unit tests for checksum parsing, version validation, retry behavior, download verification, cache refresh, and embed generation changes. |
| go/README.md | Documents the new release-asset + SHA256SUMS verification flow and the updated in-process build-tag behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
qmuntal due to an error
September 4, 2026 09:55
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
SteveSandersonMS
marked this pull request as draft
September 4, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This brings the Go bundler in line with the release-based runtime packaging used across the other SDKs. Most of the change establishes parity around artifact provenance, integrity verification, and reliable acquisition; the remaining changes simplify Go's generated embedding and installation paths.
SHA256SUMS.txtTesting
go test ./cmd/bundler ./internal/embeddedcli -count=1go vet ./cmd/bundler ./internal/embeddedclicopilot_inprocessbinaries against a local release mirror