iframe-proxy | Sunbelt Computer Software

183 lines (134 loc) · 3.32 KB

package minioExtensions
func negatedThenBranchGood() {
	if !(errorSource() == ErrNone) {
		// Good: an error means we return early
	doSomething()
func negatedThenBranchGoodWithElse() {
	if !(errorSource() == ErrNone) {
		// Good: an error means we return early
		doSomething()
	doSomething()
func negatedElseBranchGood() {
	if !(errorSource() != ErrNone) {
		doSomething()
		// Good: an error means we return early
	doSomething()
func negatedElseBranchBad() {
	if !(errorSource() != ErrNone) {
		doSomething()
		// Bad: despite an error, we carry on to execute doSomething()
		insteadOfReturn()
	doSomething()
func someOtherCondition() bool {
	return true
func logicalAndThenBranchSometimesBad() {
	if errorSource() != ErrNone && someOtherCondition() {
		// Bad: there is a route from a positive error test around the 'return' statement.
	doSomething()
func logicalAndThenBranchAlwaysBad() {
	if errorSource() != ErrNone && someOtherCondition() {
		// Bad: there is no return statement at all.
		insteadOfReturn()
	doSomething()
func logicalAndElseBranchAlwaysBad2() {
	if errorSource() == ErrNone && someOtherCondition() {
		doSomething()
		// Bad: there is no return statement at all.
		insteadOfReturn()
	doSomething()
func logicalAndThenBranchGood() {
	if someOtherCondition() && errorSource() != ErrNone {
		// Good: whenever an error is indicated we return (note errorSource() is not called until someOtherCondition() passes)
	doSomething()
func logicalAndElseBranchGood() {
	if someOtherCondition() && errorSource() == ErrNone {
		// Good: whenever an error is indicated we return (note errorSource() is not called until someOtherCondition() passes)
		doSomething()
func logicalAndElseBranchGood2() {
	if errorSource() == ErrNone && someOtherCondition() {
		// Good: whenever an error is indicated we return.
		doSomething()
	doSomething()
func logicalOrElseBranchSometimesBad() {
	if errorSource() == ErrNone || someOtherCondition() {
		doSomething()
		// Bad: there is a route from a failing error test that bypasses the return statement.
	doSomething()
func logicalOrElseBranchAlwaysBad() {
	if errorSource() == ErrNone || someOtherCondition() {
		doSomething()
		// Bad: regardless of error status, we do not return.
		insteadOfReturn()
	doSomething()
func logicalOrThenBranchAlwaysBad() {
	if errorSource() != ErrNone || someOtherCondition() {
		// Bad: regardless of error status, we do not return.
		insteadOfReturn()
		doSomething()
	doSomething()
func logicalOrThenBranchGood() {
	if someOtherCondition() || errorSource() != ErrNone {
		// Good: whenever an error is indicated we return. (note errorSource() is not called until someOtherCondition() fails)
	doSomething()
func logicalOrElseBranchGood() {
	if someOtherCondition() || errorSource() == ErrNone {
		// Good: whenever an error is indicated we return. (note errorSource() is not called until someOtherCondition() fails)
		doSomething()
func logicalOrThenBranchGood2() {
	if errorSource() != ErrNone || someOtherCondition() {
		// Good: whenever an error is indicated we return.
	doSomething()

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

FilesExpand file tree

logicalOperators.go

Latest commit

History

logicalOperators.go

File metadata and controls