Merge pull request #4044 from github/mbg/ff/promote-toolcache · github/codeql-action@3434fbb · GitHub
Skip to content

Commit 3434fbb

Browse files
authored
Merge pull request #4044 from github/mbg/ff/promote-toolcache
Promote `AllowToolcacheInput` feature
2 parents 4c0a1f0 + 3013ac0 commit 3434fbb

4 files changed

Lines changed: 11 additions & 49 deletions

File tree

‎lib/entry-points.js‎

Lines changed: 4 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/feature-flags.ts‎

Lines changed: 0 additions & 6 deletions

‎src/setup-codeql.test.ts‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ test.serial(
451451
async (t) => {
452452
const loggedMessages: LoggedMessage[] = [];
453453
const logger = getRecordingLogger(loggedMessages);
454-
const features = createFeatures([Feature.AllowToolcacheInput]);
454+
const features = createFeatures([]);
455455

456456
const latestToolcacheVersion = "3.2.1";
457457
const latestVersionPath = "/path/to/latest";
@@ -580,7 +580,7 @@ const toolcacheInputFallbackMacro = makeMacro({
580580

581581
toolcacheInputFallbackMacro.serial(
582582
"the toolcache doesn't have a CodeQL CLI when tools == toolcache",
583-
[Feature.AllowToolcacheInput],
583+
[],
584584
{ GITHUB_EVENT_NAME: "dynamic" },
585585
[],
586586
[
@@ -591,22 +591,14 @@ toolcacheInputFallbackMacro.serial(
591591

592592
toolcacheInputFallbackMacro.serial(
593593
"the workflow trigger is not `dynamic`",
594-
[Feature.AllowToolcacheInput],
594+
[],
595595
{ GITHUB_EVENT_NAME: "pull_request" },
596596
[],
597597
[
598598
`Ignoring 'tools: toolcache' because the workflow was not triggered dynamically.`,
599599
],
600600
);
601601

602-
toolcacheInputFallbackMacro.serial(
603-
"the feature flag is not enabled",
604-
[],
605-
{ GITHUB_EVENT_NAME: "dynamic" },
606-
[],
607-
[`Ignoring 'tools: toolcache' because the feature is not enabled.`],
608-
);
609-
610602
test.serial(
611603
'tryGetTagNameFromUrl extracts the right tag name for a repo name containing "codeql-bundle"',
612604
(t) => {

‎src/setup-codeql.ts‎

Lines changed: 4 additions & 14 deletions

0 commit comments

Comments
 (0)