C#: Address review comments · github/codeql@fce8058 · GitHub
Skip to content

Commit fce8058

Browse files
hvitvedhvitved
committed
C#: Address review comments
1 parent 3bb3de2 commit fce8058

7 files changed

Lines changed: 121 additions & 121 deletions

File tree

‎csharp/ql/src/CSI/NullAlways.qhelp‎

Lines changed: 3 additions & 3 deletions

‎csharp/ql/src/CSI/NullAlways.ql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ import semmle.code.csharp.dataflow.Nullness
1616

1717
from Dereference d, Ssa::SourceVariable v
1818
where d.isFirstAlwaysNull(v)
19-
select d, "Variable '$@' is always null here.", v, v.toString()
19+
select d, "Variable $@ is always null here.", v, v.toString()

‎csharp/ql/src/CSI/NullMaybe.qhelp‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55

66

77
<overview>
8-
<p>If a variable is dereferenced, and the variable may have a <code>null</code>
9-
value on some execution paths leading to the dereferencing, the dereferencing
10-
may result in a <code>NullReferenceException</code>.
8+
<p>If a variable is dereferenced, for example as the qualifier in a method call, and the
9+
variable may have a <code>null</code> value on some execution paths leading to the
10+
dereferencing, the dereferencing may result in a <code>NullReferenceException</code>.
1111
</p>
1212

1313
</overview>

‎csharp/ql/src/CSI/NullMaybe.ql‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ import semmle.code.csharp.dataflow.Nullness
1717

1818
from Dereference d, Ssa::SourceVariable v, string msg, Element reason
1919
where d.isFirstMaybeNull(v.getAnSsaDefinition(), msg, reason)
20-
select d, "Variable '$@' may be null here " + msg + ".", v, v.toString(), reason, "this"
20+
select d, "Variable $@ may be null here " + msg + ".", v, v.toString(), reason, "this"

‎csharp/ql/test/query-tests/Nullness/B.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ public void OperatorCall()
3434
return !(b1 == b2);
3535
}
3636

37-
public struct CoOrds
37+
public struct Coords
3838
{
3939
public int x, y;
4040

41-
public CoOrds(int p1, int p2)
41+
public Coords(int p1, int p2)
4242
{
4343
x = p1;
4444
y = p2;

‎csharp/ql/test/query-tests/Nullness/NullAlways.expected‎

Lines changed: 38 additions & 38 deletions

0 commit comments

Comments
 (0)