Merge pull request #22337 from github/navntoft/expected-files-ctx · github/codeql@a80d7e0 · GitHub
Skip to content

Commit a80d7e0

Browse files
authored
Merge pull request #22337 from github/navntoft/expected-files-ctx
Use expected_files.add as context manager where applicable
2 parents 2b9eef5 + d32650e commit a80d7e0

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

  • java/ql/integration-tests/kotlin/all-platforms/logs
  • misc/pytest/lib
  • swift/ql/integration-tests/posix/frontend-invocations

‎java/ql/integration-tests/kotlin/all-platforms/logs/test.py‎

Lines changed: 1 addition & 2 deletions

‎misc/pytest/lib/query_suites.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ def ret(query_suite):
99
actual = sorted(actual.splitlines())
1010
actual = [os.path.relpath(q, semmle_code_dir) for q in actual]
1111
actual_file_name = query_suite + '.actual'
12-
expected_files.add(actual_file_name)
13-
(cwd / actual_file_name).write_text('\n'.join(actual) + '\n')
12+
with expected_files.add(actual_file_name) as f:
13+
f.write('\n'.join(actual) + '\n')
1414
return ret
1515

1616
@pytest.fixture
@@ -25,6 +25,6 @@ def ret(lang_folder_name, query_suites):
2525
not_included = sorted(set(all_queries) - included_in_qls)
2626
not_included = [os.path.relpath(q, semmle_code_dir) for q in not_included]
2727
not_included_file_name = 'not_included_in_qls.actual'
28-
expected_files.add(not_included_file_name)
29-
(cwd / not_included_file_name).write_text('\n'.join(not_included) + '\n')
28+
with expected_files.add(not_included_file_name) as f:
29+
f.write('\n'.join(not_included) + '\n')
3030
return ret

‎swift/ql/integration-tests/posix/frontend-invocations/test.py‎

Lines changed: 1 addition & 2 deletions

0 commit comments

Comments
 (0)