C#: Generalize pattern definition to not only include top level patte… · github/codeql@3245151 · GitHub
Skip to content

Commit 3245151

Browse files
committed
C#: Generalize pattern definition to not only include top level pattern definitions.
1 parent a8bb94a commit 3245151

4 files changed

Lines changed: 19 additions & 12 deletions

File tree

‎csharp/ql/lib/semmle/code/csharp/Assignable.qll‎

Lines changed: 16 additions & 9 deletions

‎csharp/ql/lib/semmle/code/csharp/dataflow/Nullness.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ private predicate nonNullDef(SsaExplicitWrite def) {
110110
def.getValue() instanceof NonNullExpr
111111
or
112112
exists(AssignableDefinition ad | ad = def.getDefinition() |
113-
ad instanceof AssignableDefinitions::PatternDefinition
113+
ad instanceof AssignableDefinitions::TopLevelPatternDefinition
114114
or
115115
ad =
116116
any(AssignableDefinitions::LocalVariableDefinition d |

‎csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2677,7 +2677,7 @@ class CastNode extends Node {
26772677
this.asExpr() instanceof Cast
26782678
or
26792679
this.(AssignableDefinitionNode).getDefinition() instanceof
2680-
AssignableDefinitions::PatternDefinition
2680+
AssignableDefinitions::TopLevelPatternDefinition
26812681
}
26822682
}
26832683

‎csharp/ql/src/Dead Code/DeadStoreOfLocal.ql‎

Lines changed: 1 addition & 1 deletion

0 commit comments

Comments
 (0)