C#: Add workflow for running QL tests · github/codeql@3137675 · GitHub
Skip to content

Commit 3137675

Browse files
committed
C#: Add workflow for running QL tests
1 parent 8a73675 commit 3137675

6 files changed

Lines changed: 116 additions & 4 deletions

File tree

Lines changed: 72 additions & 0 deletions

‎.gitignore‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@
2727
# It's useful (though not required) to be able to unpack codeql in the ql checkout itself
2828
/codeql/
2929

30-
csharp/extractor/Semmle.Extraction.CSharp.Driver/Properties/launchSettings.json
31-
3230
# Avoid committing cached package components
3331
.codeql
3432

‎csharp/.gitignore‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,7 @@ csharp.log
1111
*.tlog
1212
.vs
1313
*.user
14-
.vscode/launch.json
14+
.vscode/launch.json
15+
16+
extractor/Semmle.Extraction.CSharp.Driver/Properties/launchSettings.json
17+
extractor-pack
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: Build C# CodeQL pack
2+
description: Builds the C# CodeQL pack
3+
runs:
4+
using: composite
5+
steps:
6+
- name: Setup dotnet
7+
uses: actions/setup-dotnet@v3
8+
with:
9+
dotnet-version: 6.0.202
10+
- name: Build Extractor
11+
shell: bash
12+
run: scripts/create-extractor-pack.sh
13+
working-directory: csharp

‎csharp/ql/lib/semmle/code/csharp/controlflow/internal/Completion.qll‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ abstract class Completion extends TCompletion {
103103
* otherwise it is a normal non-Boolean completion.
104104
*/
105105
predicate isValidFor(ControlFlowElement cfe) {
106-
cfe instanceof NonReturningCall and
107106
this = cfe.(NonReturningCall).getACompletion()
108107
or
109108
this = TThrowCompletion(cfe.(TriedControlFlowElement).getAThrownException())
Lines changed: 27 additions & 0 deletions

0 commit comments

Comments
 (0)