iframe-proxy | Sunbelt Computer Software

67 lines (60 loc) · 1.82 KB

 * @name Inefficient use of key set iterator
 * @description Iterating through the values of a map using the key set is inefficient.
 * @kind problem
 * @problem.severity recommendation
 * @precision high
 * @id java/inefficient-key-set-iterator
 * @tags efficiency
 *       maintainability
import java
/** A local variable that is initialized using a key-set iterator. */
class KeySetIterator extends LocalVariableDecl {
  KeySetIterator() {
    exists(LocalVariableDeclExpr lvde, MethodAccess init |
      lvde.getVariable() = this and
      lvde.getInit() = init and
      init.getMethod().hasName("iterator") and
      init.getQualifier().(MethodAccess).getMethod().hasName("keySet")
  LocalVariableDecl getBase() {
    exists(LocalVariableDeclExpr lvde, MethodAccess init |
      lvde.getVariable() = this and
      lvde.getInit() = init and
      init.getQualifier().(MethodAccess).getQualifier().(VarAccess).getVariable() = result
predicate isKeyNext(Expr e, KeySetIterator it) {
  exists(MethodAccess ma | ma = e |
    ma.getMethod().hasName("next") and
    ma.getQualifier().(VarAccess).getVariable() = it
  isKeyNext(e.(CastExpr).getExpr(), it)
class Key extends LocalVariableDecl {
    exists(LocalVariableDeclExpr lvde, KeySetIterator it |
      lvde.getVariable() = this and
      isKeyNext(lvde.getInit(), it)
  KeySetIterator getBase() {
    exists(LocalVariableDeclExpr lvde |
      lvde.getVariable() = this and
      isKeyNext(lvde.getInit(), result)
from MethodAccess ma, Method get
  ma.getMethod() = get and
  get.hasName("get") and
  ma.getAnArgument().(VarAccess).getVariable().(Key).getBase().getBase() = ma
        .getQualifier()
        .(VarAccess)
        .getVariable()
select ma, "Inefficient use of key set iterator instead of entry set iterator."

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

FilesExpand file tree

InefficientKeySetIterator.ql

Latest commit

History

InefficientKeySetIterator.ql

File metadata and controls