iframe-proxy | Sunbelt Computer Software

22 lines (20 loc) · 653 Bytes

 * @name Inefficient empty string test
 * @description Checking a string for equality with an empty string is inefficient.
 * @kind problem
 * @problem.severity recommendation
 * @precision high
 * @id java/inefficient-empty-string-test
 * @tags efficiency
 *       maintainability
import java
from MethodAccess mc
  mc.getQualifier().getType() instanceof TypeString and
  mc.getMethod().hasName("equals") and
    mc.getArgument(0).(StringLiteral).getRepresentedString() = "" or
    mc.getQualifier().(StringLiteral).getRepresentedString() = ""
select mc, "Inefficient comparison to empty string, check for zero length instead."

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

FilesExpand file tree

InefficientEmptyStringTest.ql

Latest commit

History

InefficientEmptyStringTest.ql

File metadata and controls