FilesExpand file tree

main

/

MismatchInMultipleAssignment.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

62 lines (57 loc) · 1.86 KB

main

/

MismatchInMultipleAssignment.ql

Copy path

Top

File metadata and controls

• Code
• Blame

62 lines (57 loc) · 1.86 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

40

41

42

43

44

45

46

47

48

49

50

51

52

53

54

55

56

57

58

59

60

61

62

/**

* @name Mismatch in multiple assignment

* @description Assigning multiple variables without ensuring that you define a

* value for each variable causes an exception at runtime.

* @kind problem

* @tags quality

* reliability

* correctness

* @problem.severity error

* @sub-severity low

* @precision very-high

* @id py/mismatched-multiple-assignment

*/

import python

private import LegacyPointsTo

private int len(ExprList el) { result = count(el.getAnItem()) }

predicate mismatched(Assign a, int lcount, int rcount, Location loc, string sequenceType) {

exists(ExprList l, ExprList r |

(

a.getATarget().(Tuple).getElts() = l or

a.getATarget().(List).getElts() = l

) and

(

a.getValue().(Tuple).getElts() = r and sequenceType = "tuple"

or

a.getValue().(List).getElts() = r and sequenceType = "list"

) and

loc = a.getValue().getLocation() and

lcount = len(l) and

rcount = len(r) and

lcount != rcount and

not exists(Starred s | l.getAnItem() = s or r.getAnItem() = s)

)

}

predicate mismatched_tuple_rhs(Assign a, int lcount, int rcount, Location loc) {

exists(ExprList l, TupleValue r, AstNode origin |

(

a.getATarget().(Tuple).getElts() = l or

a.getATarget().(List).getElts() = l

) and

a.getValue().(ExprWithPointsTo).pointsTo(r, origin) and

loc = origin.getLocation() and

lcount = len(l) and

rcount = r.length() and

lcount != rcount and

not l.getAnItem() instanceof Starred

)

}

from Assign a, int lcount, int rcount, Location loc, string sequenceType

where

mismatched(a, lcount, rcount, loc, sequenceType)

or

mismatched_tuple_rhs(a, lcount, rcount, loc) and

sequenceType = "tuple"

select a,

"Left hand side of assignment contains " + lcount +

" variables, but right hand side is a $@ of length " + rcount + ".", loc, sequenceType