FilesExpand file tree

 main

/

IterableStringOrSequence.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

39 lines (36 loc) · 1.22 KB

 main

/

IterableStringOrSequence.ql

Top

File metadata and controls

• Code
• Blame

39 lines (36 loc) · 1.22 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

39

/**

* @name Iterable can be either a string or a sequence

* @description Iteration over either a string or a sequence in the same loop can cause errors that are hard to find.

* @kind problem

* @tags quality

* reliability

* correctness

* @problem.severity error

* @sub-severity low

* @precision high

* @id py/iteration-string-and-sequence

*/

import python

private import LegacyPointsTo

import semmle.python.filters.Tests

predicate has_string_type(Value v) {

v.getClass() = ClassValue::str()

or

v.getClass() = ClassValue::unicode() and major_version() = 2

}

from

For loop, ControlFlowNodeWithPointsTo iter, Value str, Value seq, ControlFlowNode seq_origin,

ControlFlowNode str_origin

where

loop.getIter().getAFlowNode() = iter and

iter.pointsTo(str, str_origin) and

iter.pointsTo(seq, seq_origin) and

has_string_type(str) and

seq.getClass().isIterable() and

not has_string_type(seq) and

// suppress occurrences from tests

not seq_origin.getScope().getScope*() instanceof TestScope and

not str_origin.getScope().getScope*() instanceof TestScope

select loop,

"Iteration over $@, of class " + seq.getClass().getName() + ", may also iterate over $@.",

seq_origin, "sequence", str_origin, "string"