FilesExpand file tree

 main

/

C_StyleParentheses.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

35 lines (33 loc) · 1.08 KB

 main

/

C_StyleParentheses.ql

Top

File metadata and controls

• Code
• Blame

35 lines (33 loc) · 1.08 KB

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

/**

* @name C-style condition

* @description Putting parentheses around a condition in an 'if' or 'while' statement is

* unnecessary and harder to read.

* @kind problem

* @tags maintainability

* @problem.severity recommendation

* @sub-severity low

* @deprecated

* @precision very-high

* @id py/c-style-parentheses

*/

import python

from Expr e, Location l, string kind, string what

where

e.isParenthesized() and

not e instanceof Tuple and

(

exists(If i | i.getTest() = e) and kind = "if" and what = "condition"

or

exists(While w | w.getTest() = e) and kind = "while" and what = "condition"

or

exists(Return r | r.getValue() = e) and kind = "return" and what = "value"

or

exists(Assert a | a.getTest() = e and not exists(a.getMsg())) and

kind = "assert" and

what = "test"

) and

// These require parentheses

(not e instanceof Yield and not e instanceof YieldFrom and not e instanceof GeneratorExp) and

l = e.getLocation() and

l.getStartLine() = l.getEndLine()

select e, "Parenthesized " + what + " in '" + kind + "' statement."