FilesExpand file tree

main

/

MissedAllOpportunity.ql

Copy path

Blame

More file actions

Blame

More file actions

Latest commit

 

History

History

History

38 lines (35 loc) · 975 Bytes

main

/

MissedAllOpportunity.ql

Copy path

Top

File metadata and controls

• Code
• Blame

38 lines (35 loc) · 975 Bytes

Raw

Copy raw file

Download raw file

Open symbols panel

Edit and raw actions

1

2

3

4

5

6

7

8

9

10

11

12

13

14

15

16

17

18

19

20

21

22

23

24

25

26

27

28

29

30

31

32

33

34

35

36

37

38

/**

* @name Missed opportunity to use All

* @description The intent of a foreach loop that checks whether every element of its target sequence satisfies some predicate can be expressed

* more directly using LINQ's 'All' method.

* @kind problem

* @problem.severity recommendation

* @precision high

* @id cs/linq/missed-all

* @tags quality

* maintainability

* readability

* language-features

*/

import Linq.Helpers

/*

* The purpose of this query is to find loops of the following form:

*

* bool allEven = true;

* foreach(int i in lst)

* {

* if(i % 2 != 0)

* {

* allEven = false;

* break;

* }

* }

*

* This could be written more cleanly as:

*

* bool allEven = lst.All(i => i % 2 == 0);

*/

from ForEachStmtGenericEnumerable fes

where missedAllOpportunity(fes)

select fes,

"This foreach loop looks as if it might be testing whether every sequence element satisfies a predicate - consider using '.All(...)'."