iframe-proxy | Sunbelt Computer Software

28 lines (25 loc) · 883 Bytes

 * @name Block with too many statements
 * @description Blocks with too many consecutive statements are candidates for refactoring. Only complex statements are counted here
 *              (eg. 'for', 'while', 'switch' ...). The top-level logic will be clearer if each complex statement is extracted
 *              to a function.
 * @kind problem
 * @problem.severity recommendation
 * @precision high
 * @id cs/complex-block
 * @tags maintainability
 *       complexity
 *       testability
import csharp
class ComplexStmt extends Stmt {
  ComplexStmt() {
    this instanceof ForStmt or
    this instanceof WhileStmt or
    this instanceof DoStmt or
    this instanceof SwitchStmt
from BlockStmt b, int n
where n = count(ComplexStmt s | s = b.getAStmt()) and n > 3
select b, "Block with too many statements (" + n.toString() + " complex statements in the block)."

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

FilesExpand file tree

BlockWithTooManyStatements.ql

Latest commit

History

BlockWithTooManyStatements.ql

File metadata and controls