iframe-proxy | Sunbelt Computer Software

22 lines (20 loc) · 728 Bytes

 * @name Null argument to Equals(object)
 * @description Calls of the form 'o.Equals(null)' always return false for non-null 'o', and
 *              throw a 'NullReferenceException' when 'o' is null.
 * @kind problem
 * @problem.severity warning
 * @precision high
 * @id cs/null-argument-to-equals
 * @tags quality
 *       reliability
 *       correctness
import csharp
import semmle.code.csharp.frameworks.System
from MethodCall c, EqualsMethod equals
  c.getTarget().getUnboundDeclaration() = equals and
  c.getArgument(0) instanceof NullLiteral and
  not c.getQualifier().getType() instanceof NullableType
select c, "Equality test with 'null' will never be true, but may throw a 'NullReferenceException'."

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Uh oh!

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

FilesExpand file tree

NullArgumentToEquals.ql

Latest commit

History

NullArgumentToEquals.ql

File metadata and controls