Clarify proxy fallback behavior · Issue #308 · getsentry/sentry-python · GitHub
Skip to content

Clarify proxy fallback behavior #308

Description

@crepererum

I am currently working on #178 and extended the tests for the proxy selection mechanism, especially when the env variables like HTTP_PROXY and HTTPS_PROXY are present. One thing that I've observed is the fallback behavior:

  • no ENV vars: HTTPS DSNs can fallback to HTTP proxies (see test)
  • only HTTP_PROXY env var: no fallback for HTTPS DSNs, i.e. no proxy is auto-selected

Is that behavior intended or a bug? In either case, my PR for #178 will also include tests (and potential fixes) for that.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions