Consider Separate flow for Spans Events · Issue #1954 · getsentry/sentry-php · GitHub
Skip to content

Consider Separate flow for Spans Events #1954

Description

@Litarnus

Instead of using applyToEvent for every type, we can split them by type.

This would help in a few ways:

  • More clarity what each type does and what data it needs
  • Prevents that data is accidentally attached to wrong types (e.g. tags on logs)
  • We could have different Event types with their own data instead of one big class with the union of all fields
  • (theoretical) performance gains by reducing the number of type checks and data copy operations

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions