Don't prepend an empty font family when only fontFamilyFallback is set · flutter/flutter@9354471 · GitHub
Skip to content

Commit 9354471

Browse files
committed
Don't prepend an empty font family when only fontFamilyFallback is set
TextStyle stored a null fontFamily as '', and ParagraphBuilder.pushStyle always prepended it, so the font families passed to the engine were ['', ...fontFamilyFallback]. This made the default font take precedence over fontFamilyFallback[0], contrary to the TextStyle docs. Fixes #194543
1 parent 6597889 commit 9354471

2 files changed

Lines changed: 14 additions & 9 deletions

File tree

‎engine/src/flutter/lib/ui/text.dart‎

Lines changed: 4 additions & 9 deletions

‎engine/src/flutter/testing/dart/paragraph_test.dart‎

Lines changed: 10 additions & 0 deletions

0 commit comments

Comments
 (0)