@@ -28,7 +28,7 @@ CreateIndexDialog::~CreateIndexDialog()
 void CreateIndexDialog::tableChanged(const QString& new_table)
 {
     // And fill the table again
-    QStringList fields = pdb->getTableFields(new_table);
+    QStringList fields = pdb->getObjectByName(new_table).table.fieldNames();
     ui->tableIndexColumns->setRowCount(fields.size());
     for(int i=0; i < fields.size(); ++i)
     {
 
@@ -755,28 +755,9 @@ objectMap DBBrowserDB::getBrowsableObjects() const
     return res;
 }
 
-QStringList DBBrowserDB::getTableFields(const QString & tablename) const
-{
-    objectMap::ConstIterator it;
-    QStringList res;
-
-    for ( it = objMap.begin(); it != objMap.end(); ++it )
-    {
-        if((*it).getname() == tablename)
-        {
-            for(int i=0;i<(*it).table.fields().size();i++)
-                res.append((*it).table.fields().at(i)->name());
-        }
-    }
-    return res;
-}
-
 DBBrowserObject DBBrowserDB::getObjectByName(const QString& name) const
 {
-    objectMap::ConstIterator it;
-    QStringList res;
-
-    for ( it = objMap.begin(); it != objMap.end(); ++it )
+    for (objectMap::ConstIterator it = objMap.begin(); it != objMap.end(); ++it )
     {
         if((*it).getname() == name)
             return *it;
 
@@ -29,14 +29,6 @@ class DBBrowserObject
     QString getsql() const { return sql; }
     QString gettype() const { return type; }
     QString getTableName() const { return table_name; }
-    sqlb::FieldPtr getField(const QString& name)
-    {
-        int id = table.findField(name);
-        if(id == -1)
-            return sqlb::FieldPtr();
-        else
-            return table.fields().at(id);
-    }
     sqlb::Table table;
 private:
     QString name;
@@ -93,7 +85,6 @@ class DBBrowserDB : public QObject
      */
     bool renameColumn(const QString& tablename, const QString& name, sqlb::FieldPtr to, int move = 0);
 
-    QStringList getTableFields(const QString & tablename) const;
     QStringList getBrowsableObjectNames() const;
     objectMap getBrowsableObjects() const;
     DBBrowserObject getObjectByName(const QString& name) const;
 
@@ -42,7 +42,7 @@ void SqliteTableModel::setTable(const QString& table)
         if(t.name() != "") // parsing was OK
         {
             m_headers.push_back(t.rowidColumn());
-            m_headers.append(m_db->getTableFields(table));
+            m_headers.append(m_db->getObjectByName(table).table.fieldNames());
         }
         else
         {
 
@@ -118,6 +118,16 @@ QStringList Table::fieldList() const
     return sl;
 }
 
+QStringList Table::fieldNames() const
+{
+    QStringList sl;
+
+    foreach(FieldPtr f, m_fields)
+        sl << f->name();
+
+    return sl;
+}
+
 bool Table::hasAutoIncrement() const
 {
     foreach(FieldPtr f, m_fields) {
 
@@ -97,6 +97,7 @@ class Table
     bool removeField(const QString& sFieldName);
     void setFields(const FieldVector& fields);
     void setField(int index, FieldPtr f) { m_fields[index] = f; }
+    QStringList fieldNames() const;
     void setRowidColumn(const QString& rowid) {  m_rowidColumn = rowid; }
     const QString& rowidColumn() const { return m_rowidColumn; }
     bool isWithoutRowidTable() const { return m_rowidColumn != "_rowid_"; }
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ CreateIndexDialog::~CreateIndexDialog()`
`28`	`28`	`void CreateIndexDialog::tableChanged(const QString& new_table)`
`29`	`29`	`{`
`30`	`30`	`// And fill the table again`
`31`		`- QStringList fields = pdb->getTableFields(new_table);`
	`31`	`+ QStringList fields = pdb->getObjectByName(new_table).table.fieldNames();`
`32`	`32`	`ui->tableIndexColumns->setRowCount(fields.size());`
`33`	`33`	`for(int i=0; i < fields.size(); ++i)`
`34`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ void SqliteTableModel::setTable(const QString& table)`
`42`	`42`	`if(t.name() != "") // parsing was OK`
`43`	`43`	`{`
`44`	`44`	`m_headers.push_back(t.rowidColumn());`
`45`		`- m_headers.append(m_db->getTableFields(table));`
	`45`	`+ m_headers.append(m_db->getObjectByName(table).table.fieldNames());`
`46`	`46`	`}`
`47`	`47`	`else`
`48`	`48`	`{`