Fixes found with credentials.

sigmavirus24 · sigmavirus24 · commit e1868025a978 · 2012-09-04T10:38:30.000-04:00
That accidental deletion in tests/base.py really prevented me from finding a
lot of errors sooner but hey, at least I found them, right?
diff --git a/github3/repos.py b/github3/repos.py
@@ -95,8 +95,8 @@ def add_collaborator(self, login):
         """
         resp = False
         if login:
-            url = self._api + '/collaborators/' + login
-            resp = self._put(url)
+            url = self._build_url('collaborators', login, base_url=self._api)
+            resp = self._boolean(self._put(url), 204, 404)
         return resp
 
     def archive(self, format, path='', ref='master'):
diff --git a/tests/test_api.py b/tests/test_api.py
@@ -93,4 +93,5 @@ def test_authorize(self):
                 'Test github3.py',
                 'https://github.com/sigmavirus24/github3.py')
         expect(authorization).isinstance(github3.github.Authorization)
+        authorization._session.auth = (self.user, self.pw)
         expect(authorization.delete()).is_True()
diff --git a/tests/test_github.py b/tests/test_github.py
@@ -120,7 +120,7 @@ def test_issues(self):
         if self.auth:
             i = self._g.create_issue(self.gh3py, self.test_repo,
             'Testing github3.py', 'Ignore this.')
-            expect(i).isinstance(github3.issue.Issue)
+            expect(i).isinstance(github3.issues.Issue)
             expect(i.close()).is_True()
 
     def test_keys(self):
diff --git a/tests/test_orgs.py b/tests/test_orgs.py
@@ -69,7 +69,7 @@ def test_with_auth(self):
         org = Organization(self.org.to_json(), self._g)
         try:
             expect(org.add_member('jcordasc', 'Collaborators')).is_True()
-            expect(org.remove_member('jcordasc', 'Collaborators')).is_True()
+            expect(org.remove_member('jcordasc')).is_True()
         except github3.GitHubError:
             pass
 
@@ -120,5 +120,5 @@ def test_with_auth(self):
 class TestTeam(BaseTest):
     pass
 
-# I have to decide how to test Teams. They're all entirely dependent upon 
+# I have to decide how to test Teams. They're all entirely dependent upon
 # being authenticated and being part of an organization.
diff --git a/tests/test_pulls.py b/tests/test_pulls.py
@@ -140,7 +140,8 @@ def test_user(self):
     def test_with_auth(self):
         if not self.auth:
             return
-        pr = self._g.repository(self.gh3py, self.test_repo)
+        r = self._g.repository(self.gh3py, self.test_repo)
+        pr = r.pull_request(2)
         title, body, state = pr.title, pr.body, pr.state
         expect(pr.update('Test editing', 'New body')).is_True()
         expect(pr.update(title, body, state)).is_True()
diff --git a/tests/test_users.py b/tests/test_users.py
@@ -59,7 +59,7 @@ def test_requires_auth(self):
             self.user.list_org_events(self.gh3py)
             self.user.update()
 
-    def test_authenticated(self):
+    def test_with_auth(self):
         if not self.auth:
             return
         user = self._g.user()
