Experiment with replication specs for the details view [feenkcom/gtoo… · feenkcom/gtoolkit-remote@05cc1c1 · GitHub
Skip to content

Commit 05cc1c1

Browse files
committed
Experiment with replication specs for the details view [feenkcom/gtoolkit#5059]
1 parent e2fee7b commit 05cc1c1

6 files changed

Lines changed: 40 additions & 24 deletions

File tree

src/GToolkit-RemoteGt-InspectorCore/GtLocalPhlowViewedObject.class.st

Lines changed: 2 additions & 1 deletion

src/GToolkit-RemotePhlow-DeclarativeActions/GtRemotePhlowSpawnObjectWrapper.class.st renamed to src/GToolkit-RemotePhlow-DeclarativeSpecification/GtRemotePhlowSpawnObjectWrapper.class.st

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,14 @@ Class {
44
#instVars : [
55
'targetObject'
66
],
7-
#category : #'GToolkit-RemotePhlow-DeclarativeActions'
7+
#category : #'GToolkit-RemotePhlow-DeclarativeSpecification'
88
}
99

10+
{ #category : #serialization }
11+
GtRemotePhlowSpawnObjectWrapper class >> replicationSpec [
12+
^#(#(#targetObject #stub))
13+
]
14+
1015
{ #category : #accessing }
1116
GtRemotePhlowSpawnObjectWrapper >> targetObject [
1217
^ targetObject

src/GToolkit-RemotePhlow-DeclarativeViews/GtPhlowDetailsViewSpecification.class.st

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ GtPhlowDetailsViewSpecification class >> fromJSONDictionary: aDictionary [
2424
{ #category : #'as yet unclassified' }
2525
GtPhlowDetailsViewSpecification >> asDictionaryForExport [
2626
^ super asDictionaryForExport
27-
at: 'rowSpecifications' put: (self rowSpecifications
28-
collect: [ :eachRowSpecification | eachRowSpecification asDictionaryForExport ]
29-
as: Array);
27+
at: 'rowSpecifications' put: ((self rowSpecifications
28+
collect: [ :eachRowSpecification | eachRowSpecification asDictionaryForExport ]) asArray);
3029
yourself
3130
]
3231

src/GToolkit-RemotePhlow-DeclarativeViews/GtRemotePhlowDataNode.class.st

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ GtRemotePhlowDataNode class >> fromJSONDictionary: aDictionary [
2323
yourself
2424
]
2525

26+
{ #category : #serialization }
27+
GtRemotePhlowDataNode class >> replicationSpec [
28+
^#(#(#targetObject #stub))
29+
]
30+
2631
{ #category : #accessing }
2732
GtRemotePhlowDataNode class >> valueType [
2833
^ GtRemotePhlowItemValue

src/GToolkit-RemotePhlow-DeclarativeViews/GtRemotePhlowDetailsRowValue.class.st

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ Class {
33
#superclass : #GtRemotePhlowItemTextualValue,
44
#instVars : [
55
'rowText',
6-
'rowValue',
7-
'rowIndex'
6+
'rowIndex',
7+
'rowValueWrapper'
88
],
99
#category : #'GToolkit-RemotePhlow-DeclarativeViews'
1010
}
@@ -23,24 +23,13 @@ GtRemotePhlowDetailsRowValue >> asDictionaryForExport [
2323
]
2424

2525
{ #category : #printing }
26-
GtRemotePhlowDetailsRowValue >> descriptionOn: aStream [
27-
aStream
28-
nextPutAll: 'index: ';
29-
print: self rowIndex;
30-
nextPutAll: '; text: ';
31-
nextPutAll: self itemText
32-
]
33-
34-
{ #category : #printing }
35-
GtRemotePhlowDetailsRowValue >> printOn: aStream [
36-
super printOn: aStream.
26+
GtRemotePhlowDetailsRowValue >> descriptionOn: aStream [
3727

38-
aStream parenthesize: [
39-
aStream
28+
aStream
4029
nextPutAll: 'index: ';
4130
print: self rowIndex;
42-
nextPutAll: '; text: ';
43-
nextPutAll: self rowText ]
31+
nextPutAll: '; '.
32+
super descriptionOn: aStream
4433
]
4534

4635
{ #category : #accessing }
@@ -55,10 +44,21 @@ GtRemotePhlowDetailsRowValue >> rowIndex: anObject [
5544

5645
{ #category : #accessing }
5746
GtRemotePhlowDetailsRowValue >> rowValue [
58-
^ rowValue
47+
^ self rowValueWrapper targetObject
5948
]
6049

6150
{ #category : #accessing }
6251
GtRemotePhlowDetailsRowValue >> rowValue: anObject [
63-
rowValue := anObject
52+
self rowValueWrapper: (GtRemotePhlowSpawnObjectWrapper new
53+
targetObject: anObject)
54+
]
55+
56+
{ #category : #accessing }
57+
GtRemotePhlowDetailsRowValue >> rowValueWrapper [
58+
^ rowValueWrapper
59+
]
60+
61+
{ #category : #accessing }
62+
GtRemotePhlowDetailsRowValue >> rowValueWrapper: aWrapper [
63+
rowValueWrapper := aWrapper
6464
]

src/GToolkit-RemotePhlow-PhlowViews/GtRemotePhlowDetailsView.class.st

Lines changed: 6 additions & 0 deletions

0 commit comments

Comments
 (0)