You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
softDelete() provider should not inherit from original params #600
So in the softDelete function the params.provider is inherited from the original method (remove), but it should be an internal call like it was in previous versions (feathers-plus) of softDelete, this was done by setting the provider inside of softDelete to undefined. This is better for permissions etc, cause for example people are allowed to delete (and so call the remove hook) but aren't allowed to patch.
Now the question is how will this be changed, are we adding that back by default like something:
I think the removeParams is more flexible in my opinion but it is also a bit double cause we have a deletedQuery, what is technically inside the params.query.
Or maybe we should add an removeProvider function, any thoughts?
Depending whats the outcome of this is I can make a PR for either implementation.
Activity
Aschmider24 commentedon Jul 30, 2024
+1 on this featuree if this is not too late.
I think the second implementation leaves the user more flexibility.
fratzinger commentedon Feb 18, 2025
Just a quick headsup. I started working on a massive rewrite of the package (#764). It's not released yet and will take a few weeks.
See https://github.com/feathersjs-ecosystem/feathers-hooks-common/blob/modernize/src/hooks/soft-delete/soft-delete.ts I added an option
transformParamswhere you can change the params however you need to.fratzinger commentedon Sep 8, 2026
This is supported by the official successor: "feathers-utils". See https://utils.feathersjs.com/hooks/soft-delete.html