JAVA-31265 Review log statements for projects - Week 8 - 2024 (#15939) · ewongithub/tutorials@3642db8 · GitHub
Skip to content

Commit 3642db8

Browse files
timis1timis1
authored
JAVA-31265 Review log statements for projects - Week 8 - 2024 (eugenp#15939)
1 parent ea96452 commit 3642db8

10 files changed

Lines changed: 115 additions & 23 deletions

File tree

‎apache-libraries-2/src/main/resources/logback.xml‎

Lines changed: 2 additions & 0 deletions

‎apache-libraries-2/src/test/resources/logback-test.xml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<configuration>
3+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
4+
<encoder>
5+
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
6+
</pattern>
7+
</encoder>
8+
</appender>
9+
10+
<root level="INFO">
11+
<appender-ref ref="STDOUT" />
12+
</root>
13+
14+
<logger name="ch.qos.logback.classic.joran.action" level="WARN"/>
15+
</configuration>

‎core-groovy-modules/core-groovy/src/test/groovy/com/baeldung/io/TraverseFileTreeUnitTest.groovy‎

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,71 @@
11
package com.baeldung.io
22

3-
import org.junit.Test
4-
53
import groovy.io.FileType
64
import groovy.io.FileVisitResult
5+
import org.junit.Test
6+
7+
import static org.junit.Assert.assertTrue
78

89
class TraverseFileTreeUnitTest {
910
@Test
1011
void whenUsingEachFile_filesAreListed() {
12+
var files = []
1113
new File('src/main/resources').eachFile { file ->
12-
println file.name
14+
files.add(file.name)
1315
}
16+
assertTrue(files.size() > 1)
1417
}
1518

1619
@Test(expected = IllegalArgumentException)
1720
void whenUsingEachFileOnAFile_anErrorOccurs() {
21+
var files = []
1822
new File('src/main/resources/ioInput.txt').eachFile { file ->
19-
println file.name
23+
files.add(file.name)
2024
}
2125
}
2226

2327
@Test
2428
void whenUsingEachFileMatch_filesAreListed() {
29+
var files = []
2530
new File('src/main/resources').eachFileMatch(~/io.*\.txt/) { file ->
26-
println file.name
31+
files.add(file.name)
2732
}
2833
}
29-
34+
3035
@Test
3136
void whenUsingEachFileRecurse_thenFilesInSubfoldersAreListed() {
37+
var files = []
3238
new File('src/main').eachFileRecurse(FileType.FILES) { file ->
33-
println "$file.parent $file.name"
39+
files.add("$file.parent $file.name")
3440
}
3541
}
36-
42+
3743
@Test
3844
void whenUsingEachFileRecurse_thenDirsInSubfoldersAreListed() {
45+
var files = []
3946
new File('src/main').eachFileRecurse(FileType.DIRECTORIES) { file ->
40-
println "$file.parent $file.name"
47+
files.add("$file.parent $file.name")
4148
}
4249
}
43-
50+
4451
@Test
4552
void whenUsingEachDirRecurse_thenDirsAndSubDirsAreListed() {
53+
var files = []
4654
new File('src/main').eachDirRecurse { dir ->
47-
println "$dir.parent $dir.name"
55+
files.add("$dir.parent $dir.name")
4856
}
4957
}
50-
58+
5159
@Test
5260
void whenUsingTraverse_thenDirectoryIsTraversed() {
61+
var files = []
5362
new File('src/main').traverse { file ->
5463
if (file.directory && file.name == 'groovy') {
5564
FileVisitResult.SKIP_SUBTREE
5665
} else {
57-
println "$file.parent - $file.name"
66+
files.add("$file.parent - $file.name")
5867
}
5968
}
69+
assertTrue(files.size() > 1)
6070
}
6171
}

‎core-groovy-modules/core-groovy/src/test/groovy/com/baeldung/stringtypes/DollarSlashyString.groovy‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ package groovy.com.baeldung.stringtypes
22

33
import org.junit.Test
44

5+
import static org.junit.Assert.assertFalse
6+
57
class DollarSlashyString {
68

79
@Test
@@ -19,6 +21,7 @@ class DollarSlashyString {
1921
- $/$$
2022
/$
2123

22-
print(dollarSlashy)
24+
//print(dollarSlashy)
25+
assertFalse(dollarSlashy.isEmpty())
2326
}
2427
}

‎core-java-modules/core-java-collections/src/test/java/com/baeldung/hashtable/HashtableUnitTest.java‎

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,15 @@ public void whenIterate_thenFailFast() {
6060
table.put(new Word("dog"), "another animal");
6161

6262
Iterator<Word> it = table.keySet().iterator();
63-
System.out.println("iterator created");
63+
// System.out.println("iterator created");
6464

6565
table.remove(new Word("dog"));
66-
System.out.println("element removed");
66+
// System.out.println("element removed");
6767

6868
while (it.hasNext()) {
6969
Word key = it.next();
70-
System.out.println(table.get(key));
70+
// System.out.println(table.get(key));
71+
assertNotNull(table.get(key));
7172
}
7273
}
7374

@@ -85,12 +86,13 @@ public void whenEnumerate_thenNotFailFast() {
8586
table.put(new Word("8"), "eight");
8687

8788
Enumeration<Word> enumKey = table.keys();
88-
System.out.println("Enumeration created");
89+
// System.out.println("Enumeration created");
8990
table.remove(new Word("1"));
90-
System.out.println("element removed");
91+
// System.out.println("element removed");
9192
while (enumKey.hasMoreElements()) {
9293
Word key = enumKey.nextElement();
93-
System.out.println(table.get(key));
94+
// System.out.println(table.get(key));
95+
assertNotNull(table.get(key));
9496
}
9597
}
9698

@@ -110,7 +112,8 @@ public void whenAddElements_thenIterationOrderUnpredicable() {
110112
Iterator<Map.Entry<Word, String>> it = table.entrySet().iterator();
111113
while (it.hasNext()) {
112114
Map.Entry<Word, String> entry = it.next();
113-
System.out.println(entry.getValue());
115+
// System.out.println(entry.getValue());
116+
assertNotNull(entry.getValue());
114117
}
115118
}
116119

‎core-java-modules/core-java-concurrency-simple/src/test/resources/logback.xml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<configuration>
3+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
4+
<encoder>
5+
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
6+
</pattern>
7+
</encoder>
8+
</appender>
9+
10+
<root level="INFO">
11+
<appender-ref ref="STDOUT" />
12+
</root>
13+
</configuration>

‎core-java-modules/core-java-httpclient/src/test/resources/logback.xml‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<configuration>
3+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
4+
<encoder>
5+
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
6+
</pattern>
7+
</encoder>
8+
</appender>
9+
10+
<root level="INFO">
11+
<appender-ref ref="STDOUT" />
12+
</root>
13+
14+
<logger name="org.eclipse.jetty.server.handler" level="WARN"/>
15+
<logger name="org.mockserver.log" level="WARN"/>
16+
</configuration>

‎core-java-modules/core-java-security-4/src/main/java/com/baeldung/enablessldebug/SSLDebugLogger.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ public static void makeHttpsRequest() throws Exception {
2323

2424
try (BufferedReader reader = new BufferedReader(new InputStreamReader(connection.getInputStream()))) {
2525
String line;
26-
logger.info("Response from " + url + ":");
26+
logger.debug("Response from " + url + ":");
2727
while ((line = reader.readLine()) != null) {
28-
logger.info(line);
28+
logger.debug(line);
2929
}
3030
}
3131
}

‎core-java-modules/core-java-security-4/src/test/resources/logback.xml‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<configuration>
3+
<appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
4+
<encoder>
5+
<pattern>%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n
6+
</pattern>
7+
</encoder>
8+
</appender>
9+
10+
<root level="INFO">
11+
<appender-ref ref="STDOUT" />
12+
</root>
13+
</configuration>

‎spring-web-modules/spring-session/spring-session-mongodb/src/test/resources/logback.xml‎

Lines changed: 17 additions & 0 deletions

0 commit comments

Comments
 (0)