Merge pull request #11253 from asgerf/merge-package-type-columns · ethanwilloner/codeql@6bffb11 · GitHub
Skip to content

Commit 6bffb11

Browse files
authored
Merge pull request github#11253 from asgerf/merge-package-type-columns
Dynamic: Merge package and type columns
2 parents 79d8444 + d2bbb61 commit 6bffb11

47 files changed

Lines changed: 3631 additions & 3651 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎javascript/ql/lib/semmle/javascript/ApiGraphs.qll‎

Lines changed: 3 additions & 0 deletions

‎javascript/ql/lib/semmle/javascript/frameworks/NoSQL.qll‎

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ private module MongoDB {
2424
override predicate row(string row) {
2525
// In Mongo version 2.x, a client and a database handle were the same concept, but in 3.x
2626
// they were separated. To handle everything with a single model, we treat them as the same here.
27-
row = "mongodb;Db;mongodb;MongoClient;"
27+
row = "mongodb.Db;mongodb.MongoClient;"
2828
}
2929
}
3030

@@ -42,11 +42,11 @@ private module MongoDB {
4242
/** A call to a MongoDB query method. */
4343
private class QueryCall extends DatabaseAccess, API::CallNode {
4444
QueryCall() {
45-
this = ModelOutput::getATypeNode("mongodb", "Collection").getAMember().getACall() and
45+
this = ModelOutput::getATypeNode("mongodb.Collection").getAMember().getACall() and
4646
not this.getCalleeName() = ["toString", "valueOf", "getLogger"]
4747
or
4848
this =
49-
ModelOutput::getATypeNode("mongodb", ["Db", "MongoClient"])
49+
ModelOutput::getATypeNode(["mongodb.Db", "mongodb.MongoClient"])
5050
.getMember(["watch", "aggregate"])
5151
.getACall()
5252
}
@@ -63,7 +63,7 @@ private module MongoDB {
6363

6464
private class Insertion extends DatabaseAccess, API::CallNode {
6565
Insertion() {
66-
this = ModelOutput::getATypeNode("mongodb", "Collection").getAMember().getACall() and
66+
this = ModelOutput::getATypeNode("mongodb.Collection").getAMember().getACall() and
6767
this.getCalleeName().matches("insert%")
6868
}
6969

@@ -105,9 +105,7 @@ private module Mongoose {
105105
private class QueryCall extends DatabaseAccess, API::CallNode {
106106
QueryCall() {
107107
this =
108-
ModelOutput::getATypeNode("mongoose", "Query")
109-
.getMember(["exec", "then", "catch"])
110-
.getACall()
108+
ModelOutput::getATypeNode("mongoose.Query").getMember(["exec", "then", "catch"]).getACall()
111109
}
112110

113111
override DataFlow::Node getAQueryArgument() { result = this.getReceiver() }
@@ -132,10 +130,10 @@ private module Mongoose {
132130
private class QueryWithCallback extends DatabaseAccess, API::CallNode {
133131
QueryWithCallback() {
134132
this =
135-
ModelOutput::getATypeNode("mongoose", ["Document", "Model", "Query"])
133+
ModelOutput::getATypeNode(["mongoose.Document", "mongoose.Model", "mongoose.Query"])
136134
.getAMember()
137135
.getACall() and
138-
this.getReturn() = ModelOutput::getATypeNode("mongoose", "Query") and
136+
this.getReturn() = ModelOutput::getATypeNode("mongoose.Query") and
139137
exists(this.getLastArgument().getABoundFunctionValue(_))
140138
}
141139

@@ -152,7 +150,7 @@ private module Mongoose {
152150

153151
QueryAwait() {
154152
astNode.getOperand().flow() =
155-
ModelOutput::getATypeNode("mongoose", "Query").getAValueReachableFromSource()
153+
ModelOutput::getATypeNode("mongoose.Query").getAValueReachableFromSource()
156154
}
157155

158156
override DataFlow::Node getAQueryArgument() { result = astNode.getOperand().flow() }
@@ -162,7 +160,7 @@ private module Mongoose {
162160

163161
class Insertion extends DatabaseAccess, API::CallNode {
164162
Insertion() {
165-
this = ModelOutput::getATypeNode("mongoose", "Model").getAMember().getACall() and
163+
this = ModelOutput::getATypeNode("mongoose.Model").getAMember().getACall() and
166164
this.getCalleeName().matches("insert%")
167165
}
168166

@@ -180,9 +178,9 @@ private module MarsDB {
180178
override predicate row(string row) {
181179
row =
182180
[
183-
"mongoose;Query;marsdb;;Member[Collection].Instance",
184-
"mongoose;Model;marsdb;;Member[Collection].Instance",
185-
"mongoose;Query;mongoose;Query;Member[sortFunc].ReturnValue",
181+
"mongoose.Query;marsdb;Member[Collection].Instance",
182+
"mongoose.Model;marsdb;Member[Collection].Instance",
183+
"mongoose.Query;mongoose.Query;Member[sortFunc].ReturnValue",
186184
]
187185
}
188186
}

‎javascript/ql/lib/semmle/javascript/frameworks/SQL.qll‎

Lines changed: 10 additions & 10 deletions

0 commit comments

Comments
 (0)