Remove ban check from /ess cleanup, no longer required. · essentials/Essentials@a44275a · GitHub
Skip to content

Commit a44275a

Browse files
committed
Remove ban check from /ess cleanup, no longer required.
Fix ban upgrade script.
1 parent 6d8d3a4 commit a44275a

6 files changed

Lines changed: 65 additions & 39 deletions

File tree

‎Essentials/src/com/earth2me/essentials/EssentialsUpgrade.java‎

Lines changed: 37 additions & 13 deletions

‎Essentials/src/com/earth2me/essentials/commands/Commandban.java‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,13 @@ public void run(final Server server, final CommandSource sender, final String co
6262
{
6363
banReason = tl("defaultBanReason");
6464
}
65-
65+
6666
Bukkit.getBanList(BanList.Type.NAME).addBan(user.getName(), banReason, null, senderName);
67-
user.getBase().kickPlayer(tl("banFormat", banReason, senderName));
6867

69-
server.getLogger().log(Level.INFO, tl("playerBanned", senderName, user.getName(), banReason));
68+
String banDisplay = tl("banFormat", banReason, senderName);
69+
70+
user.getBase().kickPlayer(banDisplay);
71+
server.getLogger().log(Level.INFO, tl("playerBanned", senderName, user.getName(), banDisplay));
7072

7173
if (nomatch)
7274
{

‎Essentials/src/com/earth2me/essentials/commands/Commandessentials.java‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -264,15 +264,14 @@ private void run_cleanup(final Server server, final CommandSource sender, final
264264
{
265265
sender.sendMessage("This sub-command will delete users who havent logged in in the last <days> days.");
266266
sender.sendMessage("Optional parameters define the minium amount required to prevent deletion.");
267-
sender.sendMessage("Unless you define larger default values, this command wil ignore people who have more than 0 money/homes/bans.");
268-
throw new Exception("/<command> cleanup <days> [money] [homes] [ban count]");
267+
sender.sendMessage("Unless you define larger default values, this command wil ignore people who have more than 0 money/homes.");
268+
throw new Exception("/<command> cleanup <days> [money] [homes]");
269269
}
270270
sender.sendMessage(tl("cleaning"));
271271

272272
final long daysArg = Long.parseLong(args[1]);
273273
final double moneyArg = args.length >= 3 ? Double.parseDouble(args[2].replaceAll("[^0-9\\.]", "")) : 0;
274274
final int homesArg = args.length >= 4 && NumberUtil.isInt(args[3]) ? Integer.parseInt(args[3]) : 0;
275-
final int bansArg = args.length >= 5 && NumberUtil.isInt(args[4]) ? Integer.parseInt(args[4]) : 0;
276275
final UserMap userMap = ess.getUserMap();
277276

278277
ess.runTaskAsynchronously(new Runnable()
@@ -289,8 +288,6 @@ public void run()
289288
continue;
290289
}
291290

292-
int ban = user.getBase().isBanned() ? 0 : 1;
293-
294291
long lastLog = user.getLastLogout();
295292
if (lastLog == 0)
296293
{
@@ -311,7 +308,7 @@ public void run()
311308
int homeCount = user.getHomes().size();
312309
double moneyCount = user.getMoney().doubleValue();
313310

314-
if ((lastLog == 0) || (ban > bansArg) || (timeDiff < milliDays)
311+
if ((lastLog == 0) || (timeDiff < milliDays)
315312
|| (homeCount > homesArg) || (moneyCount > moneyArg))
316313
{
317314
continue;

‎Essentials/src/com/earth2me/essentials/commands/Commandseen.java‎

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,15 @@ protected void seen(final Server server, final CommandSource sender, final Strin
5656
seenIP(server, sender, args[0]);
5757
return;
5858
}
59-
else if (FormatUtil.validIP(args[0]) && (server.getIPBans().contains(args[0])))
59+
else if (Bukkit.getBanList(BanList.Type.IP).isBanned(args[0]))
6060
{
6161
sender.sendMessage(tl("isIpBanned", args[0]));
6262
return;
6363
}
64-
else if (Bukkit.getBannedPlayers().contains(Bukkit.getOfflinePlayer(args[0]))) {
65-
sender.sendMessage(tl("whoisBanned", showBan ? Bukkit.getBanList(BanList.Type.NAME).getBanEntry(Bukkit.getOfflinePlayer(args[0]).getName()).getReason() : tl("true")));
64+
65+
else if (Bukkit.getBanList(BanList.Type.NAME).isBanned(args[0]))
66+
{
67+
sender.sendMessage(tl("whoisBanned", showBan ? Bukkit.getBanList(BanList.Type.NAME).getBanEntry(args[0]).getReason() : tl("true")));
6668
return;
6769
}
6870
else
@@ -168,7 +170,7 @@ private void seenIP(final Server server, final CommandSource sender, final Strin
168170
{
169171
final UserMap userMap = ess.getUserMap();
170172

171-
if (server.getIPBans().contains(ipAddress))
173+
if (Bukkit.getBanList(BanList.Type.IP).isBanned(ipAddress))
172174
{
173175
sender.sendMessage(tl("isIpBanned", ipAddress));
174176
}

‎Essentials/src/com/earth2me/essentials/commands/Commandtempban.java‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -47,26 +47,27 @@ public void run(final Server server, final CommandSource sender, final String co
4747
}
4848
final String time = getFinalArg(args, 1);
4949
final long banTimestamp = DateUtil.parseDateDiff(time, true);
50-
String stringDregs = DateUtil.removeTimePattern(time);
51-
50+
String banReason = DateUtil.removeTimePattern(time);
51+
5252
final long maxBanLength = ess.getSettings().getMaxTempban() * 1000;
5353
if (maxBanLength > 0 && ((banTimestamp - GregorianCalendar.getInstance().getTimeInMillis()) > maxBanLength)
5454
&& sender.isPlayer() && !(ess.getUser(sender.getPlayer()).isAuthorized("essentials.tempban.unlimited")))
5555
{
5656
sender.sendMessage(tl("oversizedTempban"));
5757
throw new NoChargeException();
5858
}
59-
60-
if (stringDregs.length() < 2)
59+
60+
if (banReason.length() < 2)
6161
{
62-
stringDregs = tl("defaultBanReason");
62+
banReason = tl("defaultBanReason");
6363
}
6464

6565
final String senderName = sender.isPlayer() ? sender.getPlayer().getDisplayName() : Console.NAME;
66-
final String banReason = tl("tempBanned", DateUtil.formatDateDiff(banTimestamp), senderName, stringDregs);
67-
6866
Bukkit.getBanList(BanList.Type.NAME).addBan(user.getName(), banReason, new Date(banTimestamp), senderName);
69-
user.getBase().kickPlayer(banReason);
67+
68+
String banDisplay = tl("tempBanned", DateUtil.formatDateDiff(banTimestamp), senderName, banReason);
69+
user.getBase().kickPlayer(banDisplay);
70+
server.getLogger().log(Level.INFO, tl("playerBanned", senderName, user.getName(), banDisplay));
7071

7172
final String message = tl("playerBanned", senderName, user.getName(), banReason, DateUtil.formatDateDiff(banTimestamp));
7273
server.getLogger().log(Level.INFO, message);

‎Essentials/src/messages_en.properties‎

Lines changed: 5 additions & 5 deletions

0 commit comments

Comments
 (0)