fix(ci): Ensure upload of components happens on release (#420)

finger563 · web-flow · commit f6ac595fae0a · 2025-05-06T12:28:32.000-05:00
* fix(ci): Ensure upload of components happens on release

* fix version getting when on PR

* read the error message this time

* update step name

* final upload

* use tag name from release
diff --git a/.github/workflows/upload_components.yml b/.github/workflows/upload_components.yml
@@ -4,20 +4,17 @@ on:
   # i.e. validate that the component passes all checks for being uploaded.
   pull_request:
 
-  push:
-    branches:
-      - main
-    tags:
-      # only upload components on tagged commits
-      - v*
+  release:
+    types: [published]
+
 jobs:
   upload_components:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:
           submodules: "recursive"
-      - name: Upload component to the component registry
+      - name: Upload components to the component registry
         uses: espressif/upload-components-ci-action@v2
         with:
           # Please try to keep the directories list sorted.
@@ -112,5 +109,7 @@ jobs:
             components/wifi
             components/wrover-kit
           namespace: "espp"
+          # use old version if this isn't a release for testing
+          version: ${{ github.event.release && github.event.release.tag_name || 'v0.20.2' }}
           api_token: ${{ secrets.IDF_COMPONENT_API_TOKEN }}
-          dry_run: ${{ github.ref_name != 'main' || github.repository_owner != 'esp-cpp' || ! (github.event.release && github.event.action == 'published') }}
+          dry_run: ${{ github.ref_name != 'main' || github.repository_owner != 'esp-cpp' }}
