Comparing dev...release-1.24 · elastic/mito · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/mito
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev
Choose a base ref
...
head repository: elastic/mito
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release-1.24
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 8 files changed
  • 1 contributor

Commits on Apr 21, 2026

  1. mod: update cel to v0.28.0

    cel-go v0.28.0 fixes runtime node identity retention, so also update
    tests to capture the correct expected error locations.
    
    v0.27.0 is marked as a breaking release. The breaking change
    (google/cel-go@c66b3130b) removes standard type names (int, string,
    bool, etc.) from the environment's variable declarations. Before
    this change, declaring a user variable with one of those names
    caused an "overlapping identifier" error; now user variables can
    shadow type names. Type resolution is unaffected because the
    checker falls through to the type provider. We do not declare
    any user variables with standard type names, so this has no
    impact on mito.
    
    [git-generate]
    go get google.golang.org/genproto/googleapis/rpc@v0.0.0-20260319201613-d00831a3d3e7
    go get github.com/google/cel-go@v0.28.0
    go mod tidy
    
    go run github.com/uber-go/gopatch@latest . << PATCH
    @@
    @@
    - ast, iss = cel.NewStaticOptimizer(folder).Optimize(env, ast)
    + opt, err := cel.NewStaticOptimizer(folder)
    + if err != nil {
    +     return nil, nil, nil, fmt.Errorf("failed to make new static optimizer: %v", err)
    + }
    + ast, iss = opt.Optimize(env, ast)
    
    @@
    @@
    - return types.NewErr(err.Error())
    + return types.NewErr("%v", err)
    
    @@
    var x identifier
    @@
    - return types.ValOrErr(x, "no such overload for "+name)
    + return types.ValOrErr(x, "no such overload for %s", name)
    
    PATCH
    
    sed -r -i 's/(<input>:2:6)2/\10/' testdata/serve_tls.txt
    go test -update
    efd6 committed Apr 21, 2026
    Configuration menu
    Copy the full SHA
    cf0a28f View commit details
    Browse the repository at this point in the history
  2. lib,mod: handle map[any]any and []any from cel-go v0.27.0

    cel-go v0.27.0 (google/cel-go#1261) changed ConvertToNative to
    remap interface{} targets to map[any]any for maps and []any for
    lists. This breaks type switches in makeMapStrings, makeStrings,
    and mapStrings that expected the previous map[ref.Val]ref.Val and
    []ref.Val types.
    
    Add cases for the new types, round-tripping through NativeToValue
    and ConvertToNative with an explicit target type.
    efd6 committed Apr 21, 2026
    Configuration menu
    Copy the full SHA
    0bd3cfd View commit details
    Browse the repository at this point in the history
Loading