Comparing dev...1.13 · elastic/mito · GitHub
Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: elastic/mito
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev
Choose a base ref
...
head repository: elastic/mito
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.13
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jul 22, 2024

  1. lib: fix implementation of makeAs to prevent hiding error locations 

    The previous implementation made an index call to collect the value,
hiding the location of errors from the error syntax renderer. Fix and
simplify the macro implementation to avoid this.
    @efd6
    efd6 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d315aae View commit details
    Browse the repository at this point in the history

  2. lib: fix rendering of errors containing percent symbols 

    The call to ReportErrorAtID was rendinging the error message as a format
strings, resulting in confusion when the error message included %
symbols as is common in URL. This happened because the symbols were
being interpretted as fmt verbs, so ensure that the string is rendered
verbatim by handing is to a %s verb.
    @efd6
    efd6 committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    96ae28f View commit details
    Browse the repository at this point in the history
Loading