Merged PR 9300: fix uid tests

somriar · somriar · commit a3acd8373187 · 2018-08-28T15:49:34.000Z
fix uid tests. this tests are failing on github, apparently they did not run on the builds in the internal repository.
uid tests are related to the changes made for frontload
diff --git a/dist/powerbi-client.d.ts b/dist/powerbi-client.d.ts
@@ -1,4 +1,4 @@
-/*! powerbi-client v2.6.2 | (c) 2016 Microsoft Corporation MIT */
+/*! powerbi-client v2.6.3 | (c) 2016 Microsoft Corporation MIT */
 declare module "util" {
     /**
      * Raises a custom event with event data on the specified HTML element.
diff --git a/dist/powerbi.js b/dist/powerbi.js
diff --git a/dist/powerbi.min.js b/dist/powerbi.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "powerbi-client",
-  "version": "2.6.2",
+  "version": "2.6.3",
   "description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
   "main": "dist/powerbi.js",
   "typings": "dist/powerbi-client.d.ts",
diff --git a/src/config.ts b/src/config.ts
@@ -1,5 +1,5 @@
 const config = {
-  version: '2.6.2',
+  version: '2.6.3',
   type: 'js'
 };
 
diff --git a/test/test.spec.ts b/test/test.spec.ts
@@ -251,12 +251,13 @@ describe('service', function () {
             formatLocale: 'formatName'
           }
         },
-        groupId: "fakeGroupId"
+        groupId: "fakeGroupId",
+        uniqueId: "fakeUid",
       };
 
       powerbi.embed($reportContainer[0], testConfiguration);
       var iframe = $reportContainer.find('iframe');
-      expect(iframe.attr('src')).toEqual('fakeUrl?reportId=1&language=languageName&formatLocale=formatName');
+      expect(iframe.attr('src')).toEqual('fakeUrl?reportId=1&language=languageName&formatLocale=formatName&uid=fakeUid');
     });
 
     it('if attempting to embed without specifying an embed url, throw error', function () {
@@ -650,12 +651,12 @@ describe('service', function () {
           .appendTo('#powerbi-fixture');
 
         // Act
-        let report = powerbi.embed($reportContainer[0]);
+        let report = powerbi.embed($reportContainer[0], { uniqueId: "fakeUid" });
 
         // Assert
         var iframe = $reportContainer.find('iframe');
         expect(iframe.length).toEqual(1);
-        expect(iframe.attr('src')).toEqual(embedUrl);
+        expect(iframe.attr('src')).toEqual(embedUrl + "&uid=fakeUid");
       });
 
       describe('findIdFromEmbedUrl', function () {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/! powerbi-client v2.6.2 \| (c) 2016 Microsoft Corporation MIT /`
	`1`	`+/! powerbi-client v2.6.3 \| (c) 2016 Microsoft Corporation MIT /`
`2`	`2`	`declare module "util" {`
`3`	`3`	`/**`
`4`	`4`	`* Raises a custom event with event data on the specified HTML element.`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "powerbi-client",`
`3`		`- "version": "2.6.2",`
	`3`	`+ "version": "2.6.3",`
`4`	`4`	`"description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",`
`5`	`5`	`"main": "dist/powerbi.js",`
`6`	`6`	`"typings": "dist/powerbi-client.d.ts",`