Fixup #1: fix stale ILVerify baselines and use correct cref prefixes … · dotnet/fsharp@ef670dd · GitHub
Skip to content

Commit ef670dd

Browse files
committed
Fixup #1: fix stale ILVerify baselines and use correct cref prefixes for properties/events
- ILVerify baselines referenced removed functions (parseTypePath, parseMethodCref, parsePropertyCref) that were replaced by parseCref in earlier iterations. Regenerated baselines with correct entries verified via local ILVerify run. - getImplicitTargetCrefForMember now uses P: prefix for properties and E: prefix for events instead of always using M: for all member types. This follows the doc comment ID specification correctly.
1 parent ed9cf45 commit ef670dd

3 files changed

Lines changed: 11 additions & 9 deletions

File tree

‎src/Compiler/Symbols/Symbols.fs‎

Lines changed: 9 additions & 3 deletions

‎tests/ILVerify/ilverify_FSharp.Compiler.Service_Debug_netstandard2.0.bsl‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,8 @@
4040
[IL]: Error [StackUnexpected]: : <StartupCode$FSharp-Compiler-Service>.$ServiceLexing+clo::Invoke([FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<System.Tuple`3<FSharp.Compiler.Parser+token,int32,int32>,Microsoft.FSharp.Core.Unit>)][offset 0x00000082][found Char] Unexpected type on the stack.
4141
[IL]: Error [StackUnexpected]: : <StartupCode$FSharp-Compiler-Service>.$ServiceLexing+clo::Invoke([FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<System.Tuple`3<FSharp.Compiler.Parser+token,int32,int32>,Microsoft.FSharp.Core.Unit>)][offset 0x0000008B][found Char] Unexpected type on the stack.
4242
[IL]: Error [StackUnexpected]: : <StartupCode$FSharp-Compiler-Service>.$ServiceLexing+clo::Invoke([FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<System.Tuple`3<FSharp.Compiler.Parser+token,int32,int32>,Microsoft.FSharp.Core.Unit>)][offset 0x00000094][found Char] Unexpected type on the stack.
43-
[IL]: Error [StackUnexpected]: : FSharp.Compiler.Symbols.Impl::parseTypePath(string)][offset 0x0000004D][found Char] Unexpected type on the stack.
4443
[IL]: Error [StackUnexpected]: : FSharp.Compiler.Symbols.Impl::parseNestedTypeAlternativePath(string)][offset 0x00000094][found Char] Unexpected type on the stack.
45-
[IL]: Error [StackUnexpected]: : FSharp.Compiler.Symbols.Impl::parseMethodCref(string)][offset 0x00000073][found Char] Unexpected type on the stack.
46-
[IL]: Error [StackUnexpected]: : FSharp.Compiler.Symbols.Impl::parsePropertyCref(string)][offset 0x00000057][found Char] Unexpected type on the stack.
44+
[IL]: Error [StackUnexpected]: : FSharp.Compiler.Symbols.Impl::parseCref(string)][offset 0x000000F5][found Char] Unexpected type on the stack.
4745
[IL]: Error [StackUnexpected]: : <StartupCode$FSharp-Compiler-Service>.$Symbols+fullName::Invoke([FSharp.Core]Microsoft.FSharp.Core.Unit)][offset 0x00000015][found Char] Unexpected type on the stack.
4846
[IL]: Error [StackUnexpected]: : FSharp.Compiler.CreateILModule+MainModuleBuilder::ConvertProductVersionToILVersionInfo(string)][offset 0x00000011][found Char] Unexpected type on the stack.
4947
[IL]: Error [StackUnexpected]: : FSharp.Compiler.StaticLinking+TypeForwarding::followTypeForwardForILTypeRef([FSharp.Compiler.Service]FSharp.Compiler.AbstractIL.IL+ILTypeRef)][offset 0x00000010][found Char] Unexpected type on the stack.

‎tests/ILVerify/ilverify_FSharp.Compiler.Service_Release_netstandard2.0.bsl‎

Lines changed: 1 addition & 3 deletions

0 commit comments

Comments
 (0)