Fail to build against PostgreSQL 17 · Issue #73 · documentdb/documentdb · GitHub
Skip to content

Fail to build against PostgreSQL 17 #73

Closed

Description

@Vonng

Describe the bug

Works on PostgreSQL 15 & 16, Fail on PostgreSQL 17, got build error message:

src/aggregation/bson_aggregation_output_pipeline.c: In function ‘AddTargetCollectionRTEDollarMerge’:
src/aggregation/bson_aggregation_output_pipeline.c:1275:7: error: ‘Query’ {aka ‘struct Query’} has no member named ‘mergeUseOuterJoin’
  query->mergeUseOuterJoin = true;
       ^~
make[1]: *** [<builtin>: src/aggregation/bson_aggregation_output_pipeline.o] Error 1

Environment

  • RockyLinux 8/9
  • PostgreSQL 17
  • x86_64

Reproduction Steps

Just build against PostgreSQL 17

Expected behavior

Build Pass for 15,16,17

Actual behavior

Build Success for 15,16, fail for 17

Additional context

Pull Request #74

Activity

  1. self-assigned this
    on Feb 21, 2025
  2. self-assigned this
    on Feb 21, 2025
  3. AlekSi commented on Feb 24, 2025

    @AlekSi
    Contributor
  4. Vonng commented on Feb 24, 2025

    @Vonng
    Author

    BTW, I just got RPM/DEB for PostgreSQL 15,16,17 x (EL8,EL9,Debian12,Ubuntu22,Ubuntu24).

    https://pigsty.io/ext/sim/documentdb/ . And PG 17 looks good.

  5. visridha commented on Feb 25, 2025

    @visridha
    Contributor

    @shuaitian-git for adding regress tests. The next sync will bring in changes needed for pg17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions