fix: ctx cancellation on login prompt · docker/cli@623f59b · GitHub
Skip to content

Commit 623f59b

Browse files
committed
fix: ctx cancellation on login prompt
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
1 parent 70b53a0 commit 623f59b

3 files changed

Lines changed: 77 additions & 37 deletions

File tree

‎cli/command/registry.go‎

Lines changed: 12 additions & 36 deletions

‎cli/command/registry/login.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ func runLogin(ctx context.Context, dockerCli command.Cli, opts loginOptions) err
121121
response, err = loginWithCredStoreCreds(ctx, dockerCli, &authConfig)
122122
}
123123
if err != nil || authConfig.Username == "" || authConfig.Password == "" {
124-
err = command.ConfigureAuth(dockerCli, opts.user, opts.password, &authConfig, isDefaultRegistry)
124+
err = command.ConfigureAuth(ctx, dockerCli, opts.user, opts.password, &authConfig, isDefaultRegistry)
125125
if err != nil {
126126
return err
127127
}

‎cli/command/utils.go‎

Lines changed: 64 additions & 0 deletions

0 commit comments

Comments
 (0)