{{ message }}
Repository navigation
Conversation
BuildK8sObjectListTableData in common-lib lower-cases the Table column names when it builds the row maps (keys become "sync status" / "health status"), but getApplicationListDtos looked the values up with the printer-column constants "Sync Status" / "Health Status". The lookup never matched, so the ArgoCD Apps list rendered "-" for every external Argo application even though the Kubernetes Table API returned Synced/Healthy. Lower-case the lookup keys to match what the row builder produces. Signed-off-by: kacpernajda <kacper.najda2001@gmail.com>
kasparpl
requested review from
prakarsh-dt and
vivek-devtron
as code owners
September 10, 2026 23:54
|
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7030
On the ArgoCD Apps tab every external Argo CD application shows
-as its status, andGET /orchestrator/argo-applicationreturns emptyappStatus/syncStatus, although theApplicationobjects areSynced/Healthy.BuildK8sObjectListTableData(common-libutils/k8s/K8sUtil.go) lower-cases the Table column names when it builds the row maps, so the row keys aresync status/health status.getApplicationListDtoslooked the values up with the printer-column constants"Sync Status"/"Health Status", which never match.This PR lower-cases the lookup keys (derived from the same constants, so the two places cannot drift apart again) and adds a comment explaining why.
How was this verified
POST /orchestrator/k8s/resource/listforargoproj.io/v1alpha1 Applicationon a running Devtron (1188d0b9) returnsheaders: ["name", "namespace", "sync status", "health status"]withSynced/Healthyin the rows, while the list endpoint returned empty strings.pkg/argoApplication/ArgoApplicationService.go), so nothing else changes behaviour.Checklist