{{ message }}
Fix errors when changing core and executing detekt#9246
Draft
BraisGabin wants to merge 2 commits intomainfrom
Draft
Fix errors when changing core and executing detekt#9246BraisGabin wants to merge 2 commits intomainfrom
detekt#9246BraisGabin wants to merge 2 commits intomainfrom
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #2957
We have a
ClassLoadercache. The problem was that we didn't invalidate the cache correctly. We were just looking at changes in the paths of the classpath. But if the content of any of those paths changes we should invalidate it too. That's what this PR does. Instead of hashing the paths I'm now hashing the content of those paths.There are two "problems" with this implementation:
ClassLoaders in thatConcurrentHashMap. We had the leak already but this PR makes it even worst.ClassLoaders. But with my new implementation we create aClassLoaderper module. That's bad! But If I sort the classpath that problem goes away.For the point 1 I propose to use Caffeine. For the point 2 I think that we can assume that class shadowing is not something that we don't care (because it should not happen).