ValidationException has empty message · Issue #277 · ddeboer/data-import · GitHub
Skip to content

ValidationException has empty message #277

Open

Description

@arjank

When the ValidatorFilter creates a ValidationException, the exception message is left blank. That means that when the message is sent to a logger in the StepAggregator $this->logger->error($e->getMessage());, it will send an empty message. That's not very helpful when you're trying to log why an item cannot be processed.

My suggestion would be to set the message to a string that contains the line number and a comma separated list of all the constraint violations. That way the exception message makes sense, and of course you can still process the messages later.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions