space-between-declarations fails on media queries · Issue #378 · csscomb/csscomb.js · GitHub
Skip to content

space-between-declarations fails on media queries #378

Description

@aymanrady

options/space-between-declarations.js throws error while parsing css file with media query

TypeError: Object ( has no method 'is'
    at module.exports.process (/srv/www/csscomb-testcase/node_modules/csscomb/lib/options/space-between-declarations.js:71:50)
    at Object.Node.map (/srv/www/csscomb-testcase/node_modules/csscomb/node_modules/gonzales-pe/lib/node.js:111:9)
    at /srv/www/csscomb-testcase/node_modules/csscomb/node_modules/gonzales-pe/lib/node.js:117:22
    at Array.forEach (native)
    at Object.Node.map (/srv/www/csscomb-testcase/node_modules/csscomb/node_modules/gonzales-pe/lib/node.js:115:22)
    at /srv/www/csscomb-testcase/node_modules/csscomb/node_modules/gonzales-pe/lib/node.js:117:22
    at Array.forEach (native)
    at Object.Node.map (/srv/www/csscomb-testcase/node_modules/csscomb/node_modules/gonzales-pe/lib/node.js:115:22)
    at /srv/www/csscomb-testcase/node_modules/csscomb/node_modules/gonzales-pe/lib/node.js:117:22
    at Array.forEach (native)

the problem is with this code options/space-between-declarations.js#L71

if (!node.get(i) || !node.get(i).is('declarationDelimiter')) continue;

gonzales-pe doesn't return a Node object for ( & )

simplified test-case

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions