Merge pull request #22349 from theinfosecguy/javascript-transformstre… · computersarebad/codeql@69845b1 · GitHub
Skip to content

Commit 69845b1

Browse files
authored
Merge pull request github#22349 from theinfosecguy/javascript-transformstream-constructor-arity
JavaScript: Fix TransformStream constructor arity
2 parents df9ac5b + 1c6b4b8 commit 69845b1

5 files changed

Lines changed: 48 additions & 2 deletions

File tree

‎javascript/externs/web/streamsapi.js‎

Lines changed: 20 additions & 2 deletions
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
category: minorAnalysis
3+
---
4+
* The `js/superfluous-trailing-arguments` query no longer reports valid arguments passed to the `TransformStream` constructor.

‎javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/SpuriousArguments.expected‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
| reflection.js:7:15:7:18 | 1 | Superfluous arguments passed to $@. | reflection.js:1:1:1:23 | functio ... eturn;} | function f0 |
99
| reflection.js:12:18:12:18 | 2 | Superfluous argument passed to $@. | reflection.js:2:1:2:24 | functio ... eturn;} | function f1 |
1010
| thisparameter.ts:4:11:4:12 | 45 | Superfluous argument passed to $@. | thisparameter.ts:1:1:1:45 | functio ... eturn;} | function foo |
11+
| transformstream.ts:15:33:15:34 | {} | Superfluous argument passed to $@. | externs.js:48:1:48:76 | functio ... egy) {} | function TransformStream |
1112
| tst.js:10:3:10:5 | g() | Superfluous argument passed to $@. | tst.js:1:1:4:1 | functio ... x+19;\\n} | function f |
1213
| tst.js:31:15:31:18 | 2 | Superfluous arguments passed to $@. | externs.js:34:1:34:27 | functio ... str) {} | function String |
1314
| tst.js:34:4:34:5 | 42 | Superfluous argument passed to $@. | tst.js:35:4:35:23 | function() {return;} | anonymous function |

‎javascript/ql/test/query-tests/LanguageFeatures/SpuriousArguments/externs.js‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,12 @@ function Number() {}
3939

4040
Number.parseFloat = function(num) {};
4141

42+
/**
43+
* @param {*=} transformer
44+
* @param {*=} writableStrategy
45+
* @param {*=} readableStrategy
46+
* @constructor
47+
*/
48+
function TransformStream(transformer, writableStrategy, readableStrategy) {}
49+
4250
/** @externs */
Lines changed: 15 additions & 0 deletions

0 commit comments

Comments
 (0)