TestBoost() : TestFixture("TestBoost") {}

Settings settings;

void run() OVERRIDE {

settings.severity.enable(Severity::style);

settings.severity.enable(Severity::performance);

TEST_CASE(BoostForeachContainerModification);

}

void check(const char code[]) {

// Clear the error buffer..

errout.str("");

// Tokenize..

Tokenizer tokenizer(&settings, this);

std::istringstream istr(code);

tokenizer.tokenize(istr, "test.cpp");

// Check..

CheckBoost checkBoost;

checkBoost.runChecks(&tokenizer, &settings, this);

}

void BoostForeachContainerModification() {

check("void f() {\n"

" vector<int> data;\n"

" BOOST_FOREACH(int i, data) {\n"

" data.push_back(123);\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());

check("void f() {\n"

" set<int> data;\n"

" BOOST_FOREACH(int i, data) {\n"

" data.insert(123);\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());

check("void f() {\n"

" set<int> data;\n"

" BOOST_FOREACH(const int &i, data) {\n"

" data.erase(123);\n"

" }\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());

// Check single line usage

check("void f() {\n"

" set<int> data;\n"

" BOOST_FOREACH(const int &i, data)\n"

" data.clear();\n"

"}");

ASSERT_EQUALS("[test.cpp:4]: (error) BOOST_FOREACH caches the end() iterator. It's undefined behavior if you modify the container inside.\n", errout.str());

// Container returned as result of a function -> Be quiet

check("void f() {\n"

" BOOST_FOREACH(const int &i, get_data())\n"

" data.insert(i);\n"

"}");

ASSERT_EQUALS("", errout.str());

// Break after modification (#4788)

check("void f() {\n"

" vector<int> data;\n"

" BOOST_FOREACH(int i, data) {\n"

" data.push_back(123);\n"

" break;\n"

" }\n"

"}");

ASSERT_EQUALS("", errout.str());

}