Merge branch 'develop' into fix/request-refresh-after-uri-normalization · codeigniter4/CodeIgniter4@361237b · GitHub
Skip to content

Commit 361237b

Browse files
Merge branch 'develop' into fix/request-refresh-after-uri-normalization
2 parents c247f6e + b74fff9 commit 361237b

191 files changed

Lines changed: 2475 additions & 517 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.gitattributes‎

Lines changed: 0 additions & 1 deletion

‎.github/copilot-instructions.md‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,15 @@ Prioritize actionable findings involving:
2323
## Review behavior
2424

2525
- Determine the PR base branch and apply the compatibility policy from
26-
`AGENTS.md`. If the base branch cannot be determined, assume `develop`
27-
and state that assumption.
26+
`AGENTS.md`. When it is not visible, read it from the title prefix and
27+
the labels as `AGENTS.md` describes, and otherwise assume `develop` and
28+
state that assumption.
29+
- Before reporting a compatibility break, confirm the symbol exists in the
30+
latest tagged release. A symbol introduced on the base branch since that
31+
release is unreleased and may change freely, as `AGENTS.md` describes.
32+
- Do not report a PHPStan suppression or baseline entry covered by the
33+
exceptions in `AGENTS.md`, or a missing reset of state that
34+
`CIUnitTestCase::tearDown()` already restores.
2835
- Do not report formatting-only issues already enforced by PHP-CS-Fixer.
2936
- Every finding should identify a concrete failure scenario and the
3037
affected code.

‎.github/instructions/tests.instructions.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ applyTo: "tests/**/*.php"
1414
Avoid testing private implementation details.
1515
- Restore services, factories, environment variables, superglobals, handlers,
1616
locale, time-related state, and other global state modified by a test.
17+
Check `CIUnitTestCase::tearDown()` first: a test need not repeat the
18+
resets it already performs.
1719
- Tests must not depend on execution order or state left by another test.
1820
- Do not replace a meaningful assertion with a weaker assertion to make a test
1921
pass.

‎.github/workflows/deploy-apidocs.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
persist-credentials: false
4545

4646
- name: Setup PHP
47-
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
47+
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
4848
with:
4949
php-version: '8.2'
5050
tools: phive

‎.github/workflows/deploy-userguide-latest.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
persist-credentials: false
3131

3232
- name: Setup PHP
33-
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
33+
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
3434
with:
3535
php-version: '8.2'
3636
coverage: none
@@ -59,7 +59,7 @@ jobs:
5959
6060
# Create an artifact of the html output
6161
- name: Upload artifact
62-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
62+
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
6363
with:
6464
name: HTML Documentation
6565
path: user_guide_src/build/html/

‎.github/workflows/reusable-coveralls.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ jobs:
2222
persist-credentials: false
2323

2424
- name: Setup PHP
25-
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
25+
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
2626
with:
2727
php-version: ${{ inputs.php-version }}
2828
tools: composer
2929
coverage: xdebug
3030

3131
- name: Download coverage files
32-
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
32+
uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
3333
with:
3434
path: build/cov
3535

@@ -46,10 +46,10 @@ jobs:
4646
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
4747
with:
4848
path: ${{ steps.composer-cache.outputs.COMPOSER_CACHE_FILES_DIR }}
49-
key: ${{ github.job }}-php-${{ inputs.php-version }}-${{ hashFiles('**/composer.*') }}
49+
key: composer-php-${{ inputs.php-version }}-${{ hashFiles('**/composer.json') }}
5050
restore-keys: |
51-
${{ github.job }}-php-${{ inputs.php-version }}-
52-
${{ github.job }}-
51+
composer-php-${{ inputs.php-version }}-
52+
composer-
5353
5454
- name: Cache PHPUnit's static analysis cache
5555
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0

‎.github/workflows/reusable-phpunit-test.yml‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ jobs:
175175
persist-credentials: false
176176

177177
- name: Setup PHP
178-
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
178+
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
179179
with:
180180
php-version: ${{ inputs.php-version }}
181181
tools: composer
@@ -195,11 +195,10 @@ jobs:
195195
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
196196
with:
197197
path: ${{ steps.setup-env.outputs.COMPOSER_CACHE_FILES_DIR }}
198-
key: ${{ inputs.job-id || github.job }}-php-${{ inputs.php-version }}-db-${{ inputs.db-platform || 'none' }}-${{ hashFiles('**/composer.*') }}
198+
key: composer-php-${{ inputs.php-version }}-${{ hashFiles('**/composer.json') }}
199199
restore-keys: |
200-
${{ inputs.job-id || github.job }}-php-${{ inputs.php-version }}-db-${{ inputs.db-platform || 'none' }}-
201-
${{ inputs.job-id || github.job }}-php-${{ inputs.php-version }}-
202-
${{ inputs.job-id || github.job }}-
200+
composer-php-${{ inputs.php-version }}-
201+
composer-
203202
204203
- name: Cache PHPUnit's static analysis cache
205204
if: ${{ inputs.enable-artifact-upload }}
@@ -233,7 +232,7 @@ jobs:
233232

234233
- name: Upload coverage results as artifact
235234
if: ${{ inputs.enable-artifact-upload }}
236-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
235+
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
237236
with:
238237
name: ${{ steps.setup-env.outputs.ARTIFACT_NAME }}
239238
path: build/cov/coverage-${{ steps.setup-env.outputs.ARTIFACT_NAME }}.cov

‎.github/workflows/reusable-serviceless-phpunit-test.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ jobs:
7272
fetch-depth: 0
7373

7474
- name: Setup PHP
75-
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
75+
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
7676
with:
7777
php-version: ${{ inputs.php-version }}
7878
tools: composer
@@ -92,10 +92,10 @@ jobs:
9292
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
9393
with:
9494
path: ${{ steps.setup-env.outputs.COMPOSER_CACHE_FILES_DIR }}
95-
key: ${{ inputs.job-id || github.job }}-php-${{ inputs.php-version }}-${{ hashFiles('**/composer.*') }}
95+
key: composer-php-${{ inputs.php-version }}-${{ hashFiles('**/composer.json') }}
9696
restore-keys: |
97-
${{ inputs.job-id || github.job }}-php-${{ inputs.php-version }}-
98-
${{ inputs.job-id || github.job }}-
97+
composer-php-${{ inputs.php-version }}-
98+
composer-
9999
100100
- name: Cache PHPUnit's static analysis cache
101101
if: ${{ inputs.enable-artifact-upload }}
@@ -127,7 +127,7 @@ jobs:
127127

128128
- name: Upload coverage results as artifact
129129
if: ${{ inputs.enable-artifact-upload }}
130-
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
130+
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
131131
with:
132132
name: ${{ steps.setup-env.outputs.ARTIFACT_NAME }}
133133
path: build/cov/coverage-${{ steps.setup-env.outputs.ARTIFACT_NAME }}.cov

‎.github/workflows/run-carson.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
runs-on: ubuntu-24.04
3333
steps:
3434
- name: Run Carson
35-
uses: NexusPHP/carson@cb35604ab330c2e44dba673fcef712c78e75f858 # v1.7.0
35+
uses: NexusPHP/carson@53c45cf25e2303bc503209f8b5dd9107f27b2e8f # v1.8.0
3636
with:
3737
app_id: ${{ secrets.CARSON_APP_ID }}
3838
private_key: ${{ secrets.CARSON_PRIVATE_KEY }}

‎.github/workflows/test-autoreview.yml‎

Lines changed: 0 additions & 76 deletions

0 commit comments

Comments
 (0)