remove_by_value implementation in singly_linked_list_exercise.py · Issue #54 · codebasics/data-structures-algorithms-python · GitHub
Skip to content

remove_by_value implementation in singly_linked_list_exercise.py #54

Open
Open
remove_by_value implementation in singly_linked_list_exercise.py#54

Description

@satadrubasu
satadrubasu
opened on May 11, 2022

https://github.com/codebasics/data-structures-algorithms-python/blob/master/data_structures/3_LinkedList/Solution/singly_linked_list_exercise.py

Proposed below :

        if not self.head:
            return

        if self.head.val == value:
            self.head = self.head.next
            return

        itr = self.head
        prev_node = None
        while itr:
            if itr.val == value:
                prev_node.next = itr.next
            prev_node = itr
            itr = itr.next

Activity

  1. gurashish1singh commented on Nov 5, 2022

    @gurashish1singh
    gurashish1singh
    on Nov 5, 2022

    You can simplify all the logic with just one while loop:

    def remove_by_value(self, value_to_remove: Any) -> None:
        itr = self.head
        while itr:
            if value_to_remove == itr.next_value.data:
                itr.next_value = itr.next_value.next_value
                return
            itr = itr.next_value

        raise ValueError(f"{value_to_remove = } not found in the linked list")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions